From: RChan <rspchan@starhub.net.sg>
To: sparclinux@vger.kernel.org
Subject: [PATCH] sunsu.c
Date: Wed, 20 Oct 2004 03:04:52 +0000 [thread overview]
Message-ID: <4175D5D4.3090702@starhub.net.sg> (raw)
The following patch fixes an oops in the serial subsystem
when using a agetty/login on ttyS[01] reported by me on the
mailing list. I suspect member values from the uart_sunsu_port structure are
not correctly transferred to the uart_port structure?
System: Sun Fire V210
Kernel: 2.6.[89]
Problem report:
http://marc.theaimsgroup.com/?l=linux-sparc&m\x109819243824775&w=2
--- linux.old/drivers/serial/sunsu.c.ORIG 2004-10-20
10:03:52.000000000 +0800
+++ linux/drivers/serial/sunsu.c 2004-10-20 10:43:40.000000000 +0800
@@ -689,6 +690,7 @@
} else {
retval = request_irq(up->irq, sunsu_serial_interrupt,
SA_SHIRQ, su_typev[up->su_type], up);
+ port->irq = up->irq;
}
if (retval) {
printk("su: Cannot register IRQ %d\n", up->irq);
Somehow the irq setting is not transferred to the uart_port structure
causing
a later oops in synchronize_irq due to NULL pointer dereference. I am
now able to login on ttyS[01].
The kernel still reports irq as 0 during booting; I am still trying to
track this
one down. Any pointers as to the earliest stage at which port->irq has
supposedly been
set to a "good" value, and where does 2.4.2[67] get values for
interrupts such as 4,7ac
from? (BTW I am a total newbie to the Sparc architecture so please forgive
the dumb questions.)
next reply other threads:[~2004-10-20 3:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-20 3:04 RChan [this message]
2004-10-21 5:19 ` [PATCH] sunsu.c David S. Miller
2004-10-21 8:30 ` RChan
2004-10-31 21:45 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4175D5D4.3090702@starhub.net.sg \
--to=rspchan@starhub.net.sg \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.