All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: netdev@oss.sgi.com, Rusty Russell <rusty@rustcorp.com.au>,
	netfilter-devel@lists.netfilter.org
Subject: Re: [PATCH] Change masquerade code to use first IP address of	interface.
Date: Wed, 20 Oct 2004 19:42:15 +0200	[thread overview]
Message-ID: <4176A377.8@trash.net> (raw)
In-Reply-To: <E1CKBtq-0005FC-00@gondolin.me.apana.org.au>

Herbert Xu wrote:

>Rusty Russell <rusty@rustcorp.com.au> wrote:
>  
>
>>+       newsrc = inet_select_addr(out, 0, RT_SCOPE_UNIVERSE);
>>+       if (!newsrc) {
>>+               printk("MASQUERADE: %s ate my IP address\n", out->name);
>>+               return NF_DROP;
>>    
>>
>
>Wouldn't it be better to select the address for the gateway that we're
>sending towards?
>  
>

I agree. Rusty, I already have your patch queued in a
post-2.6.9 tree, I'm going to add Herbert's patch on top.

Regards
Patrick

      parent reply	other threads:[~2004-10-20 17:42 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-10-20  2:58 [PATCH] Change masquerade code to use first IP address of interface Rusty Russell
2004-10-20  8:28 ` Herbert Xu
2004-10-20  8:32 ` Herbert Xu
2004-10-20  9:24   ` Henrik Nordstrom
2004-10-20 10:46     ` Herbert Xu
2004-10-20 11:04       ` Henrik Nordstrom
2004-10-20 11:12         ` Herbert Xu
2004-10-21  0:50           ` Rusty Russell
2004-10-21  5:29             ` David S. Miller
2004-10-20 17:42   ` Patrick McHardy [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4176A377.8@trash.net \
    --to=kaber@trash.net \
    --cc=herbert@gondor.apana.org.au \
    --cc=netdev@oss.sgi.com \
    --cc=netfilter-devel@lists.netfilter.org \
    --cc=rusty@rustcorp.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.