All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bodo Stroesser <bstroesser@fujitsu-siemens.com>
To: BlaisorBlade <blaisorblade_spam@yahoo.it>
Cc: user-mode-linux-devel@lists.sourceforge.net, jdike@addtoit.com
Subject: Re: [uml-devel] Re: [patch 1/1] SYSEMU: avoid intercepting syscall on return when using SYSCALL again.
Date: Fri, 22 Oct 2004 18:23:37 +0200	[thread overview]
Message-ID: <41793409.70001@fujitsu-siemens.com> (raw)
In-Reply-To: <200410221814.45917.blaisorblade_spam@yahoo.it>

BlaisorBlade wrote:
> On Friday 22 October 2004 11:22, Bodo Stroesser wrote:
> 
>>blaisorblade_spam@yahoo.it wrote:
>>
>>>From: Bodo Stroesser <bstroesser@fujitsu-siemens.com>
>>>
>>>A guest process switching from using PTRACE_SYSEMU to PTRACE_SYSCALL
>>>crashes.
>>>
>>>The problem is in arch/i386/kernel/entry.S. The current SYSEMU patch
>>>inhibits the syscall-handler to be called, but does not prevent
>>>do_syscall_trace to be called after this for syscall completion
>>>interception.
>>>
>>>The appended patch fixes this. It reuses the flag TIF_SYSCALL_EMU to
>>>remember "we come from PTRACE_SYSEMU and now are in PTRACE_SYSCALL",
>>>since the flag is unused in the depicted situation.
>>>
>>>The patch is tested, AFAICS, it works fine, i.e. sysemu can be switched
>>>on and off dynamically without crash.
>>>
>>>Bodo
>>>
>>>Signed-off-by: Paolo 'Blaisorblade' Giarrusso
>>><blaisorblade_spam@yahoo.it> ---
>>
>>Fine idea to move one part of the patch to sys_ptrace()!
>>But maybe you missed to reset TIF_SYSCALL_EMU while resuming with
>>PTRACE_CONT? Here is a revised patch.
> 
> Yes - I forgot it. Does the revised version work? My version did not - it 
> failed the startup test. In fact, PTRACE_CONT is called in the startup test 
> (which fails). I'm recompiling and testing.
Yes. My system works very fine with it.

Regards
> 
> Thanks again.



-------------------------------------------------------
This SF.net email is sponsored by: IT Product Guide on ITManagersJournal
Use IT products in your business? Tell us what you think of them. Give us
Your Opinions, Get Free ThinkGeek Gift Certificates! Click to find out more
http://productguide.itmanagersjournal.com/guidepromo.tmpl
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel

  reply	other threads:[~2004-10-22 16:17 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-10-21 23:18 [uml-devel] [patch 1/1] SYSEMU: avoid intercepting syscall on return when using SYSCALL again blaisorblade_spam
2004-10-22  0:37 ` BlaisorBlade
2004-10-22  9:22 ` [uml-devel] " Bodo Stroesser
2004-10-22 16:14   ` BlaisorBlade
2004-10-22 16:23     ` Bodo Stroesser [this message]
2004-10-27 14:21       ` Bodo Stroesser
2004-10-28 23:04         ` Blaisorblade
2004-10-28 23:36           ` Bodo Stroesser
     [not found]             ` <200410290200.46907.blaisorblade_spam@yahoo.it>
2004-10-29  1:19               ` Bodo Stroesser
2004-10-29  7:51                 ` Gerd Knorr
2004-10-29 13:09                   ` Blaisorblade

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=41793409.70001@fujitsu-siemens.com \
    --to=bstroesser@fujitsu-siemens.com \
    --cc=blaisorblade_spam@yahoo.it \
    --cc=jdike@addtoit.com \
    --cc=user-mode-linux-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.