From: Jeff Garzik <jgarzik@pobox.com>
To: Linus Torvalds <torvalds@osdl.org>, Hanna Linder <hannal@us.ibm.com>
Cc: Andrew Morton <akpm@osdl.org>,
Linux Kernel <linux-kernel@vger.kernel.org>,
Greg KH <greg@kroah.com>
Subject: Re: Compile breakage from me
Date: Mon, 25 Oct 2004 16:20:33 -0400 [thread overview]
Message-ID: <417D6011.2040003@pobox.com> (raw)
In-Reply-To: <Pine.LNX.4.58.0410251024290.27766@ppc970.osdl.org>
Linus Torvalds wrote:
>
> On Mon, 25 Oct 2004, Linus Torvalds wrote:
>
>>How about just sending me the for_each_pci_dev() macro instead?
>
>
> Never mind. I just picked it up directly from my kernel mailing list
> archives instead - Hanna had already signed off on it.
hmmmm, so where do the 'gotten' references go?
> --- a/drivers/char/hw_random.c 2004-10-25 16:18:50 -04:00
> +++ b/drivers/char/hw_random.c 2004-10-25 16:18:50 -04:00
> @@ -581,7 +581,7 @@
> DPRINTK ("ENTER\n");
>
> /* Probe for Intel, AMD RNGs */
> - while ((pdev = pci_find_device(PCI_ANY_ID, PCI_ANY_ID, pdev)) != NULL) {
> + for_each_pci_dev(pdev) {
> +#define for_each_pci_dev(d) while ((d = pci_get_device(PCI_ANY_ID, PCI_ANY_ID, d)) != NULL)
Jeff
prev parent reply other threads:[~2004-10-25 20:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-25 17:05 Compile breakage from me Jeff Garzik
2004-10-25 17:13 ` Linus Torvalds
2004-10-25 17:25 ` Linus Torvalds
2004-10-25 17:43 ` Jeff Garzik
2004-10-25 20:20 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=417D6011.2040003@pobox.com \
--to=jgarzik@pobox.com \
--cc=akpm@osdl.org \
--cc=greg@kroah.com \
--cc=hannal@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.