From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from galahad.ideasonboard.com ([185.26.127.97]:48719 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751316AbdIOSUR (ORCPT ); Fri, 15 Sep 2017 14:20:17 -0400 From: Laurent Pinchart To: kieran.bingham@ideasonboard.com Cc: linux-renesas-soc@vger.kernel.org, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH v1 2/3] drm: rcar-du: Add suspend resume helpers Date: Fri, 15 Sep 2017 21:20:18 +0300 Message-ID: <41822401.KNpIGo2cP1@avalon> In-Reply-To: <3416c30a-620c-0238-2569-02de80a53ba2@ideasonboard.com> References: <1607973.DTifMlLdNl@avalon> <3416c30a-620c-0238-2569-02de80a53ba2@ideasonboard.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-renesas-soc-owner@vger.kernel.org List-ID: Hi Kieran, On Friday, 15 September 2017 20:49:15 EEST Kieran Bingham wrote: > On 15/09/17 18:02, Laurent Pinchart wrote: > > On Friday, 15 September 2017 19:42:06 EEST Kieran Bingham wrote: > >> The pipeline needs to ensure that the hardware is idle for suspend and > >> resume operations. > > > > I'm not sure to really understand this sentence. > > It makes sense to me ... :) - But I'm not the (only) target audience. > > How about re-wording it in a similar way to your suggestion in [1/3] > > """ > To support system suspend operations we must ensure the hardware is stopped, > and resumed explicitly from the suspend and resume handlers. > > Implement suspend and resume functions using the DRM atomic helper > functions. > """ Sounds good to me. I'll update the commit message in my tree, and update the subject line to "drm: rcar-du: Implement system suspend/resume support". > >> Implement suspend and resume functions using the DRM atomic helper > >> functions. > >> > >> CC: dri-devel@lists.freedesktop.org > >> > >> Signed-off-by: Kieran Bingham > > > > The rest of the patch looks good to me. With the commit message clarified, > > > > Reviewed-by: Laurent Pinchart > > > >> --- > >> > >> drivers/gpu/drm/rcar-du/rcar_du_drv.c | 18 +++++++++++++++--- > >> drivers/gpu/drm/rcar-du/rcar_du_drv.h | 1 + > >> 2 files changed, 16 insertions(+), 3 deletions(-) [snip] -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH v1 2/3] drm: rcar-du: Add suspend resume helpers Date: Fri, 15 Sep 2017 21:20:18 +0300 Message-ID: <41822401.KNpIGo2cP1@avalon> References: <1607973.DTifMlLdNl@avalon> <3416c30a-620c-0238-2569-02de80a53ba2@ideasonboard.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from galahad.ideasonboard.com (galahad.ideasonboard.com [185.26.127.97]) by gabe.freedesktop.org (Postfix) with ESMTPS id 300896ECE4 for ; Fri, 15 Sep 2017 18:20:17 +0000 (UTC) In-Reply-To: <3416c30a-620c-0238-2569-02de80a53ba2@ideasonboard.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: kieran.bingham@ideasonboard.com Cc: linux-renesas-soc@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org SGkgS2llcmFuLAoKT24gRnJpZGF5LCAxNSBTZXB0ZW1iZXIgMjAxNyAyMDo0OToxNSBFRVNUIEtp ZXJhbiBCaW5naGFtIHdyb3RlOgo+IE9uIDE1LzA5LzE3IDE4OjAyLCBMYXVyZW50IFBpbmNoYXJ0 IHdyb3RlOgo+ID4gT24gRnJpZGF5LCAxNSBTZXB0ZW1iZXIgMjAxNyAxOTo0MjowNiBFRVNUIEtp ZXJhbiBCaW5naGFtIHdyb3RlOgo+ID4+IFRoZSBwaXBlbGluZSBuZWVkcyB0byBlbnN1cmUgdGhh dCB0aGUgaGFyZHdhcmUgaXMgaWRsZSBmb3Igc3VzcGVuZCBhbmQKPiA+PiByZXN1bWUgb3BlcmF0 aW9ucy4KPiA+IAo+ID4gSSdtIG5vdCBzdXJlIHRvIHJlYWxseSB1bmRlcnN0YW5kIHRoaXMgc2Vu dGVuY2UuCj4gCj4gSXQgbWFrZXMgc2Vuc2UgdG8gbWUgLi4uIDopIC0gQnV0IEknbSBub3QgdGhl IChvbmx5KSB0YXJnZXQgYXVkaWVuY2UuCj4gCj4gSG93IGFib3V0IHJlLXdvcmRpbmcgaXQgaW4g YSBzaW1pbGFyIHdheSB0byB5b3VyIHN1Z2dlc3Rpb24gaW4gWzEvM10KPiAKPiAiIiIKPiBUbyBz dXBwb3J0IHN5c3RlbSBzdXNwZW5kIG9wZXJhdGlvbnMgd2UgbXVzdCBlbnN1cmUgdGhlIGhhcmR3 YXJlIGlzIHN0b3BwZWQsCj4gYW5kIHJlc3VtZWQgZXhwbGljaXRseSBmcm9tIHRoZSBzdXNwZW5k IGFuZCByZXN1bWUgaGFuZGxlcnMuCj4gCj4gSW1wbGVtZW50IHN1c3BlbmQgYW5kIHJlc3VtZSBm dW5jdGlvbnMgdXNpbmcgdGhlIERSTSBhdG9taWMgaGVscGVyCj4gZnVuY3Rpb25zLgo+ICIiIgoK U291bmRzIGdvb2QgdG8gbWUuIEknbGwgdXBkYXRlIHRoZSBjb21taXQgbWVzc2FnZSBpbiBteSB0 cmVlLCBhbmQgdXBkYXRlIHRoZSAKc3ViamVjdCBsaW5lIHRvICJkcm06IHJjYXItZHU6IEltcGxl bWVudCBzeXN0ZW0gc3VzcGVuZC9yZXN1bWUgc3VwcG9ydCIuCgo+ID4+IEltcGxlbWVudCBzdXNw ZW5kIGFuZCByZXN1bWUgZnVuY3Rpb25zIHVzaW5nIHRoZSBEUk0gYXRvbWljIGhlbHBlcgo+ID4+ IGZ1bmN0aW9ucy4KPiA+PiAKPiA+PiBDQzogZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9y Zwo+ID4+IAo+ID4+IFNpZ25lZC1vZmYtYnk6IEtpZXJhbiBCaW5naGFtIDxraWVyYW4uYmluZ2hh bStyZW5lc2FzQGlkZWFzb25ib2FyZC5jb20+Cj4gPiAKPiA+IFRoZSByZXN0IG9mIHRoZSBwYXRj aCBsb29rcyBnb29kIHRvIG1lLiBXaXRoIHRoZSBjb21taXQgbWVzc2FnZSBjbGFyaWZpZWQsCj4g PiAKPiA+IFJldmlld2VkLWJ5OiBMYXVyZW50IFBpbmNoYXJ0IDxsYXVyZW50LnBpbmNoYXJ0QGlk ZWFzb25ib2FyZC5jb20+Cj4gPiAKPiA+PiAtLS0KPiA+PiAKPiA+PiAgZHJpdmVycy9ncHUvZHJt L3JjYXItZHUvcmNhcl9kdV9kcnYuYyB8IDE4ICsrKysrKysrKysrKysrKy0tLQo+ID4+ICBkcml2 ZXJzL2dwdS9kcm0vcmNhci1kdS9yY2FyX2R1X2Rydi5oIHwgIDEgKwo+ID4+ICAyIGZpbGVzIGNo YW5nZWQsIDE2IGluc2VydGlvbnMoKyksIDMgZGVsZXRpb25zKC0pCgpbc25pcF0KCi0tIApSZWdh cmRzLAoKTGF1cmVudCBQaW5jaGFydAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJl ZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGlu Zm8vZHJpLWRldmVsCg==