All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jgarzik@pobox.com>
To: "Malte Schröder" <MalteSch@gmx.de>
Cc: linux-kernel@vger.kernel.org, Daniele Venzano <webvenza@libero.it>
Subject: Re: [PATCH] WOL for sis900
Date: Sat, 30 Oct 2004 12:13:39 -0400	[thread overview]
Message-ID: <4183BDB3.8000302@pobox.com> (raw)
In-Reply-To: <4183B6B0.7010906@gmx.de>

Malte Schröder wrote:
> Hello,
> I have applied the patch from http://lkml.org/lkml/2003/7/16/88 manually 
> to 2.6.7 (also works on 2.6.{8,9}) and have been using it since then.
> Attached is a diff against 2.6.9.

Two comments:

1) Please include a signed-off-by line, as per

	http://linux.yyz.us/patch-format.html
		and
	http://www.zip.com.au/~akpm/linux/patches/stuff/tpp.txt

2) Please use ethtool to enable/disable WOL.  No need for a module option.


  reply	other threads:[~2004-10-30 16:18 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-10-30 15:43 [PATCH] WOL for sis900 Malte Schröder
2004-10-30 16:13 ` Jeff Garzik [this message]
2004-10-30 19:00   ` Daniele Venzano
2004-10-31 13:08     ` Malte Schröder
2004-11-10  2:58 ` Rusty Russell
2004-11-10  5:21   ` Malte Schröder
2004-11-10 20:40   ` Daniele Venzano
2004-11-10 21:24     ` Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4183BDB3.8000302@pobox.com \
    --to=jgarzik@pobox.com \
    --cc=MalteSch@gmx.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=webvenza@libero.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.