Re: [PATCH 2.6.10-rc1] ahci: Intel ICH6R (925X) corrections

[Jeff Garzik <jgarzik@pobox.com>]

Matthijs Melchior wrote:
> This patch makes the following changes to drivers/scsi/ahci.c
> 
> - Add definition for SActive register
> - Add most interrupt sources to default interrupt mask
> - Write low 32 bits of FIS address to PxFB, where they belong
> - Set command active bit in PxSACT before setting command issue bit in PxCI
> - Announce Sub Class Code in driver info message [IDE, SATA or RAID]
> 
> 
> ------------------------------------------------------------------------
> 
> --- a/drivers/scsi/ahci.c	2004-10-23 01:37:22.000000000 +0200
> +++ b/drivers/scsi/ahci.c	2004-10-31 00:20:13.000000000 +0200
> @@ -90,6 +90,7 @@
>  	PORT_SCR_STAT		= 0x28, /* SATA phy register: SStatus */
>  	PORT_SCR_CTL		= 0x2c, /* SATA phy register: SControl */
>  	PORT_SCR_ERR		= 0x30, /* SATA phy register: SError */
> +        PORT_SCR_ACT            = 0x34, /* SATA phy register: SActive */
>  
>  	/* PORT_IRQ_{STAT,MASK} bits */
>  	PORT_IRQ_COLD_PRES	= (1 << 31), /* cold presence detect */
> @@ -116,6 +117,9 @@
>  				  PORT_IRQ_HBUS_DATA_ERR |
>  				  PORT_IRQ_IF_ERR,
>  	DEF_PORT_IRQ		= PORT_IRQ_FATAL | PORT_IRQ_PHYRDY |
> +                                  PORT_IRQ_CONNECT | PORT_IRQ_SG_DONE |
> +                                  PORT_IRQ_UNK_FIS | PORT_IRQ_SDB_FIS |
> +                                  PORT_IRQ_DMAS_FIS | PORT_IRQ_PIOS_FIS |
>  				  PORT_IRQ_D2H_REG_FIS,
>  

oh BTW, several parts of your patch had all the tabs converted to spaces 
for some reason.  I hand-converted them back.

	Jeff