From: Jeff Garzik <jgarzik@pobox.com>
To: janitor@sternwelten.at
Cc: netdev@oss.sgi.com, nacc@us.ibm.com
Subject: Re: [patch 12/18] net/sb1000: replace nicedelay() with msleep_interruptible()
Date: Sun, 31 Oct 2004 06:05:15 -0500 [thread overview]
Message-ID: <4184C6EB.1000700@pobox.com> (raw)
In-Reply-To: <E1CO1w1-0002Uj-Hm@sputnik>
janitor@sternwelten.at wrote:
> Any comments would be appreciated.
>
> Description: Use msleep_interruptible() instead of nicedelay()
> to guarantee the task delays as expected. Remove the prototype and
> definition of nicedelay(). This is a very weird function, because it is
> called to sleep in terms of usecs, but always sleeps for 1 second,
> completely ignoring the parameter. I have gone ahead and followed suit,
> just sleeping for a second in all cases, but maybe someone with the
> hardware could tell me if perhaps the paramter *should* matter.
> Also remove a random "^L" character.
use ssleep() here too
next prev parent reply other threads:[~2004-10-31 11:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-30 22:42 [patch 12/18] net/sb1000: replace nicedelay() with msleep_interruptible() janitor
2004-10-31 11:05 ` Jeff Garzik [this message]
2004-11-01 19:29 ` [KJ] [PATCH] net/sb1000: replace nicedelay() with Nishanth Aravamudan
2004-11-01 20:24 ` [PATCH] net/sb1000: replace nicedelay() with ssleep_interruptible() Nishanth Aravamudan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4184C6EB.1000700@pobox.com \
--to=jgarzik@pobox.com \
--cc=janitor@sternwelten.at \
--cc=nacc@us.ibm.com \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.