From: Jeff Garzik <jgarzik@pobox.com>
To: janitor@sternwelten.at
Cc: netdev@oss.sgi.com, nacc@us.ibm.com, kas@fi.muni.cz
Subject: Re: [patch 06/18] net/cosa: replace schedule_timeout() with msleep_interruptible()
Date: Sun, 31 Oct 2004 06:08:15 -0500 [thread overview]
Message-ID: <4184C79F.3090602@pobox.com> (raw)
In-Reply-To: <E1CO1vg-00027C-CO@sputnik>
janitor@sternwelten.at wrote:
> Any comments would be appreciated. Two patches have been removed from my
> set, so the total has been reduced to 38.
>
> Description: Use msleep_interruptible() instead of schedule_timeout()
> to guarantee the task delays as expected. Also use set_current_state()
> instaed of direct assignment of current->state.
>
> Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>
> Acked-by: Jan Kasprzak <kas@fi.muni.cz>
> Signed-off-by: Maximilian Attems <janitor@sternwelten.at>
>
> ---
>
> linux-2.6.10-rc1-max/drivers/net/wan/cosa.c | 9 ++++-----
> 1 files changed, 4 insertions(+), 5 deletions(-)
>
> diff -puN drivers/net/wan/cosa.c~msleep-drivers_net_wan_cosa drivers/net/wan/cosa.c
> --- linux-2.6.10-rc1/drivers/net/wan/cosa.c~msleep-drivers_net_wan_cosa 2004-10-24 17:05:02.000000000 +0200
> +++ linux-2.6.10-rc1-max/drivers/net/wan/cosa.c 2004-10-24 17:05:02.000000000 +0200
> @@ -543,7 +543,7 @@ static int cosa_probe(int base, int irq,
> * FIXME: When this code is not used as module, we should
> * probably call udelay() instead of the interruptible sleep.
> */
> - current->state = TASK_INTERRUPTIBLE;
> + set_current_state(TASK_INTERRUPTIBLE);
> cosa_putstatus(cosa, SR_TX_INT_ENA);
> schedule_timeout(30);
> irq = probe_irq_off(irqs);
> @@ -1564,8 +1564,7 @@ static int cosa_reset_and_read_id(struct
> cosa_getdata8(cosa);
> cosa_putstatus(cosa, SR_RST);
> #ifdef MODULE
> - current->state = TASK_INTERRUPTIBLE;
> - schedule_timeout(HZ/2);
> + msleep_interruptible(500);
> #else
> udelay(5*100000);
> #endif
> @@ -1618,7 +1617,7 @@ static int get_wait_data(struct cosa_dat
> return r;
> }
> /* sleep if not ready to read */
> - current->state = TASK_INTERRUPTIBLE;
> + set_current_state(TASK_INTERRUPTIBLE);
> schedule_timeout(1);
> }
> printk(KERN_INFO "cosa: timeout in get_wait_data (status 0x%x)\n",
> @@ -1645,7 +1644,7 @@ static int put_wait_data(struct cosa_dat
> }
> #if 0
> /* sleep if not ready to read */
> - current->state = TASK_INTERRUPTIBLE;
> + set_current_state(TASK_INTERRUPTIBLE);
> schedule_timeout(1);
> #endif
why add all the memory barriers and such associated with
set_current_state() ?
next prev parent reply other threads:[~2004-10-31 11:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-30 22:42 [patch 06/18] net/cosa: replace schedule_timeout() with msleep_interruptible() janitor
2004-10-31 11:08 ` Jeff Garzik [this message]
2004-11-01 11:23 ` Jan Kasprzak
2004-11-01 22:00 ` Nishanth Aravamudan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4184C79F.3090602@pobox.com \
--to=jgarzik@pobox.com \
--cc=janitor@sternwelten.at \
--cc=kas@fi.muni.cz \
--cc=nacc@us.ibm.com \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.