From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] net/ixgbe: fix link never come up problem with x552 Date: Fri, 11 Nov 2016 00:49:23 +0100 Message-ID: <4185992.QHLedvsRzY@xps13> References: <1478674828-41011-1-git-send-email-wei.zhao1@intel.com> <6A0DE07E22DDAD4C9103DF62FEBC09093934229A@shsmsx102.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, "Lu, Wenzhuo" To: "Zhao1, Wei" Return-path: Received: from mail-wm0-f42.google.com (mail-wm0-f42.google.com [74.125.82.42]) by dpdk.org (Postfix) with ESMTP id B0C9AD4B4 for ; Fri, 11 Nov 2016 00:49:25 +0100 (CET) Received: by mail-wm0-f42.google.com with SMTP id t79so62873625wmt.0 for ; Thu, 10 Nov 2016 15:49:25 -0800 (PST) In-Reply-To: <6A0DE07E22DDAD4C9103DF62FEBC09093934229A@shsmsx102.ccr.corp.intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > > From: zhao wei > > > > The links never coming up with DPDK16.11 when bring up x552 NIC, device id is > > 15ac.This is caused by delete some code which casing removes X550em SFP iXFI > > setup for the drivers in function ixgbe_setup_mac_link_sfp_x550em().Fix > > methord is recover the deleted code. > > > > Fixes: 1726b9cd9c40 ("net/ixgbe/base: remove X550em SFP iXFI setup") > > > > Signed-off-by: zhao wei > Acked-by: Wenzhuo Lu > Thanks for the patch. It's a critical issue. We need to fix it. I'll report it to our kernel driver developers. Applied, thanks