Greg KH wrote:
> On Tue, Oct 19, 2004 at 12:22:49PM +0100, David Vrabel wrote:
> 
>>The plan was to make the CardBus driver (drivers/pcmcia/yenta_socket.c) 
>>honour the is_bridge flag and not bother with CardBus stuff if it's cleared.
> 
> But why can't any code that wants to check this, just look at the
> dev->hdr_type instead?  I don't think we need to add a new bit for this
> because of that, right?

Using the is_bridge flag allows PCI device fixups to disable the CardBus 
portion of the driver.  And you obviously can't tweak the hdr_type since 
the device header is still a CardBus/bridge type header.

e.g., I have:

static void __devinit pci_fixup_mercury_pci1520(struct pci_dev *dev)
{
         if (!machine_is_arcom_mercury())
                 return;

         dev->is_bridge = 0;
}
DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_TI, PCI_DEVICE_ID_TI_1520, 
pci_fixup_mercury_pci1520);

> Also, your patch was linewrapped :(

Hmm.  Looks fine here.  I've attached it instead this time.

David Vrabel
-- 
David Vrabel, Design Engineer

Arcom, Clifton Road           Tel: +44 (0)1223 411200 ext. 3233
Cambridge CB1 7EA, UK         Web: http://www.arcom.com/