From: Jeff Garzik <jgarzik@pobox.com>
To: Mikael Starvik <mikael.starvik@axis.com>
Cc: linux-kernel@vger.kernel.org, akpm@osdl.org
Subject: Re: [PATCH 3/10] CRIS architecture update - Ethernet
Date: Tue, 02 Nov 2004 14:47:57 -0500 [thread overview]
Message-ID: <4187E46D.8020402@pobox.com> (raw)
In-Reply-To: <BFECAF9E178F144FAEF2BF4CE739C668014C7487@exmail1.se.axis.com>
Mikael Starvik wrote:
> Update ethernet driver to use generic mii interface.
>
> Signed-Off-By: starvik@axis.com
overall, looks OK to me.
There are a few places when you indented using spaces, while the
surrounding code uses tabs for indentation.
Jeff
prev parent reply other threads:[~2004-11-02 19:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-02 13:04 [PATCH 3/10] CRIS architecture update - Ethernet Mikael Starvik
2004-11-02 19:47 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4187E46D.8020402@pobox.com \
--to=jgarzik@pobox.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mikael.starvik@axis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.