Re: [PATCH] add requeue task

[Nick Piggin <nickpiggin@yahoo.com.au>]

Nikita Danilov wrote:
> Nick Piggin writes:
>  > Con Kolivas wrote:
>  > > add requeue task

>  > >  /*
>  > > + * Put task to the end of the run list without the overhead of dequeue
>  > > + * followed by enqueue.
>  > > + */
>  > > +static void requeue_task(struct task_struct *p, prio_array_t *array)
>  > > +{
>  > > +	list_del(&p->run_list);
>  > > +	list_add_tail(&p->run_list, array->queue + p->prio);
>  > > +}
> 
> Shouldn't this be
> 
> list_move_tail(&p->run_list, array->queue + p->prio);
> 
> ?
> 

I think it should indeed.