From: "Péter Ujfalusi" <peter.ujfalusi@ti.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: alsa-devel@alsa-project.org,
"Janusz Krzysztofik" <jkrzyszt@tis.icnet.pl>,
"Gražvydas Ignotas" <notasas@gmail.com>,
"Anuj Aggarwal" <anuj.aggarwal@ti.com>,
"Misael Lopez Cruz" <misael.lopez@ti.com>,
"Liam Girdwood" <lrg@ti.com>,
"Jarkko Nikula" <jarkko.nikula@bitmer.com>
Subject: Re: [PATCH] ASoC: OMAP machines: Fix kernel crash due to changes in core
Date: Fri, 07 Oct 2011 14:46:13 +0300 [thread overview]
Message-ID: <4189395.0St6XppZfI@barack> (raw)
In-Reply-To: <1923772.Cd9hLQzlop@barack>
On Friday 07 October 2011 14:12:43 Péter Ujfalusi wrote:
> As I said: sdp4430 strated to crash yesterday morning - without any change
> in the sdp4430 driver.
bisect given me this commit:
commit 35c64bcad5c8244d973efbf7e58f6e0e09635504
Author: Mark Brown <broonie@opensource.wolfsonmicro.com>
Date: Wed Sep 28 18:23:53 2011 +0100
ASoC: Ensure all DAPM widgets have a power check callback
Makes the code simpler.
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
So this means we had this issue masked by the if (!w->power_check).
Since machine drivers rarely add mixers/muxes the issue has not been really
seen.
We tend to add _SPK, _HP, and stuff like that...
But I have checked the commit before this one. While it is not crashing the
kernel it does ignores the machine added DAPM widgets. They did not power on
(they used to power on). Based on this commit this is expected behavior.
The bisected commit just masked the underlaying issue.
--
Péter
next prev parent reply other threads:[~2011-10-07 11:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-07 7:06 [PATCH] ASoC: OMAP machines: Fix kernel crash due to changes in core Peter Ujfalusi
2011-10-07 10:17 ` Mark Brown
2011-10-07 10:40 ` Péter Ujfalusi
2011-10-07 10:48 ` Mark Brown
2011-10-07 11:12 ` Péter Ujfalusi
2011-10-07 11:46 ` Péter Ujfalusi [this message]
2011-10-07 11:47 ` Mark Brown
2011-10-07 13:14 ` Péter Ujfalusi
2011-10-07 13:46 ` Mark Brown
2011-10-07 14:21 ` Péter Ujfalusi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4189395.0St6XppZfI@barack \
--to=peter.ujfalusi@ti.com \
--cc=alsa-devel@alsa-project.org \
--cc=anuj.aggarwal@ti.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=jarkko.nikula@bitmer.com \
--cc=jkrzyszt@tis.icnet.pl \
--cc=lrg@ti.com \
--cc=misael.lopez@ti.com \
--cc=notasas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.