From: Jeff Garzik <jgarzik@pobox.com>
To: Greg KH <greg@kroah.com>
Cc: Chris Wedgwood <cw@f00f.org>, LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH] deprecate pci_module_init
Date: Wed, 03 Nov 2004 20:12:53 -0500 [thread overview]
Message-ID: <41898215.4040809@pobox.com> (raw)
In-Reply-To: <20041104005107.GA15301@kroah.com>
Greg KH wrote:
> In short, pci_module_init() on 2.4 would return the number of pci
> devices bound to the device, on 2.6, it just always returns 0 if the
> driver was successfully registered, no knowledge of how many devices
> bound are ever returned.
Incorrect. pci_register_driver() is the inconsistent one, as I've
explained before (months ago).
pci_module_init() always returns 0 or an errno-based value, in 2.4 or
2.6. Thus is it the portable alternative.
Thus, changing drivers -away from- pci_module_init() makes them less
portable, for zero apparent gain. It's just a #define symbol at this
point, leave it be.
The cost of "#define pci_module_init pci_register_driver" is zero, while
the cost and impact of changing tons of drivers to the non-portable
variant is non-zero.
Jeff
next prev parent reply other threads:[~2004-11-04 1:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-03 9:10 [PATCH] deprecate pci_module_init Chris Wedgwood
2004-11-03 17:46 ` Jeff Garzik
2004-11-03 19:07 ` Chris Wedgwood
2004-11-03 19:13 ` Jeff Garzik
2004-11-03 19:20 ` Chris Wedgwood
2004-11-04 0:21 ` Greg KH
2004-11-04 0:37 ` Chris Wedgwood
2004-11-04 0:51 ` Greg KH
2004-11-04 0:53 ` Chris Wedgwood
2004-11-04 1:12 ` Jeff Garzik [this message]
2004-11-03 20:33 ` Christoph Hellwig
2004-11-03 20:49 ` Chris Wedgwood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41898215.4040809@pobox.com \
--to=jgarzik@pobox.com \
--cc=akpm@osdl.org \
--cc=cw@f00f.org \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.