All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jim Nelson <james4765@verizon.net>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] hw_random: Update printk()'s in hw_random.c
Date: Sat, 06 Nov 2004 13:27:41 -0500	[thread overview]
Message-ID: <418D179D.50301@verizon.net> (raw)
In-Reply-To: <418D0623.8000302@pobox.com>

>>  /*
>>   * debugging macros
>>   */
>> -#undef RNG_DEBUG /* define to enable copious debugging info */
>> +#undef DEBUG /* define to enable copious debugging info */
> 
> 
> I think the '#undef DEBUG' line is supposed to precede all the 
> #includes, yes?
> 
> 

>>  static int rng_dev_open (struct inode *inode, struct file *filp);
>>  static ssize_t rng_dev_read (struct file *filp, char __user *buf, 
>> size_t size,
>> -                 loff_t * offp);
>> +        loff_t * offp);
> 
> 
> seemingly bogus whitespace change
> 
> 

>> -    bytes_out = xstore(&via_rng_datum, VIA_RNG_CHUNK_1) & 
>> VIA_XSTORE_CNT_MASK;
>> +    bytes_out = xstore(&via_rng_datum, VIA_RNG_CHUNK_1) &
>> +            VIA_XSTORE_CNT_MASK;
> 
> 
> bogus whitespace change
> -


All right.  I'll back out the whitespace changes and move the #undef to the top of 
the #includes, and re-submit.

      reply	other threads:[~2004-11-06 18:27 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-11-05 21:19 [PATCH] hw_random: Update printk()'s in hw_random.c james4765
2004-11-05 21:19 ` [PATCH] hw_random: Remove changelog from hw_random.txt james4765
2004-11-06 17:46   ` Jeff Garzik
2004-11-06 17:13 ` [PATCH] hw_random: Update printk()'s in hw_random.c Jeff Garzik
2004-11-06 18:27   ` Jim Nelson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=418D179D.50301@verizon.net \
    --to=james4765@verizon.net \
    --cc=jgarzik@pobox.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.