From: Gao Xiang <hsiangkao@linux.alibaba.com>
To: Guo Xuenan <guoxuenan@huaweicloud.com>, linux-erofs@lists.ozlabs.org
Subject: Re: [PATCH] erofs-utils: dump: add some superblock fields display
Date: Tue, 6 Jun 2023 15:58:08 +0800 [thread overview]
Message-ID: <41910cd1-ea8a-cab4-af46-eea76d6f1761@linux.alibaba.com> (raw)
In-Reply-To: <c1e01731-9922-e146-2008-b68c22926999@huaweicloud.com>
On 2023/6/6 15:28, Guo Xuenan wrote:
...
>>> +
>>> +struct available_alg {
>>> + int type;
>>> + const char *name;
>>> +};
>>
>> Could we use lib/compressor.c instead?
>>
> Take a look at the currently implemented interface, and I notice that
> compressor.c define different compressors for mkfs.erofs, but for
> dump.erofs we don't need care about that much, we only show compression
> algothrims name of the image. It seems that it cannot be reused.
Please help add erofsfsck_ prefix to available_cfg like
erofsfsck_available_cfg.
Anyway, that is still not quite clean if you take a look at
erofs_get_compress_algorithm_id() if lib/compress.c.
We could address this later.
Thanks,
Gao Xiang
next prev parent reply other threads:[~2023-06-06 7:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-06 3:55 [PATCH] erofs-utils: dump: add some superblock fields display Guo Xuenan via Linux-erofs
2023-06-06 5:27 ` Gao Xiang
2023-06-06 7:05 ` Guo Xuenan via Linux-erofs
2023-06-06 7:28 ` Guo Xuenan
2023-06-06 7:58 ` Gao Xiang [this message]
2023-06-06 8:39 ` Guo Xuenan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41910cd1-ea8a-cab4-af46-eea76d6f1761@linux.alibaba.com \
--to=hsiangkao@linux.alibaba.com \
--cc=guoxuenan@huaweicloud.com \
--cc=linux-erofs@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.