All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Randy.Dunlap" <rddunlap@osdl.org>
To: kernel-janitors@vger.kernel.org
Subject: Re: [KJ] [PATCH] convert arlan wireless driver to module_param
Date: Tue, 09 Nov 2004 21:41:14 +0000	[thread overview]
Message-ID: <4191397A.9070907@osdl.org> (raw)
In-Reply-To: <20041109213215.GC9496@dice.seeling33.de>

Stefan Sperling wrote:
> Replaces MODULE_PARM with module_param calls in arlan wireless driver.
> 
> I also reordered module parameter declarations a little to improve readability.
> All debug related parameter stuff is now declared in one block, rather than all over the place.
> Some debug related module parameters even used to be declared outside DEBUG #ifdefs.
> Generally, the arlan debug code is still broken, though. It currently does not compile,
> and this patch does not make it compile.

Did you at least make sure that (e.g.)

int debug;

is in the source file *before*

module_param(debug, bool, 0644);

This wasn't required for MODULE_PARM() -- i.e., it's different
for module_param().

> --- drivers/net/wireless/arlan-main.c.orig	2004-11-09 20:40:21.928933608 +0100
> +++ drivers/net/wireless/arlan-main.c	2004-11-08 22:28:43.000000000 +0100
> @@ -31,52 +31,46 @@ static int retries = 5;
>  static int tx_queue_len = 1;
>  static int arlan_EEPROM_bad;
>  
> -#ifdef ARLAN_DEBUGGING
> +module_param(arlan_debug, bool, 0644);
> +module_param(spreadingCode, int, 0644);
> +module_param(channelNumber, int, 0644);
> +module_param(channelSet, int, 0644);
> +module_param(systemId, int, 0644);
> +module_param(registrationMode, int, 0644);
> +module_param(radioNodeId, int, 0644);
> +module_param(SID, int, 0644);
> +module_param(keyStart, int, 0644);
> +module_param(tx_delay_ms, int, 0644);
> +module_param(retries, int, 0644);
> +module_param(tx_queue_len, int, 0644);
> +module_param(arlan_EEPROM_bad, bool, 0644);
> +MODULE_PARM_DESC(arlan_debug, "Arlan debug enable (0-1)");
> +MODULE_PARM_DESC(retries, "Arlan maximum packet retransmisions");
>  
> -static int arlan_entry_debug;
> -static int arlan_exit_debug;
> +#ifdef ARLAN_DEBUGGING
>  static int testMemory = testMemoryUNKNOWN;
>  static int irq = irqUNKNOWN;
>  static int txScrambled = 1;
>  static int mdebug;
> -#endif
> -
> -MODULE_PARM(irq, "i");
> -MODULE_PARM(mem, "i");
> -MODULE_PARM(arlan_debug, "i");
> -MODULE_PARM(testMemory, "i");
> -MODULE_PARM(spreadingCode, "i");
> -MODULE_PARM(channelNumber, "i");
> -MODULE_PARM(channelSet, "i");
> -MODULE_PARM(systemId, "i");
> -MODULE_PARM(registrationMode, "i");
> -MODULE_PARM(radioNodeId, "i");
> -MODULE_PARM(SID, "i");
> -MODULE_PARM(txScrambled, "i");
> -MODULE_PARM(keyStart, "i");
> -MODULE_PARM(mdebug, "i");
> -MODULE_PARM(tx_delay_ms, "i");
> -MODULE_PARM(retries, "i");
> -MODULE_PARM(async, "i");
> -MODULE_PARM(tx_queue_len, "i");
> -MODULE_PARM(arlan_entry_debug, "i");
> -MODULE_PARM(arlan_exit_debug, "i");
> -MODULE_PARM(arlan_entry_and_exit_debug, "i");
> -MODULE_PARM(arlan_EEPROM_bad, "i");
> -MODULE_PARM_DESC(irq, "(unused)");
> -MODULE_PARM_DESC(mem, "Arlan memory address for single device probing");
> -MODULE_PARM_DESC(arlan_debug, "Arlan debug enable (0-1)");
> +module_param(testMemory, bool, 0644);
>  MODULE_PARM_DESC(testMemory, "(unused)");
> +module_param(irq, int, 0444);
> +MODULE_PARM_DESC(irq, "(unused)");
> +module_param(txScrambled, bool, 0644);
> +module_param(mdebug, bool, 0644);
>  MODULE_PARM_DESC(mdebug, "Arlan multicast debugging (0-1)");
> -MODULE_PARM_DESC(retries, "Arlan maximum packet retransmisions");
> +#endif
> +
>  #ifdef ARLAN_ENTRY_EXIT_DEBUGGING
> +static int arlan_entry_debug;
> +static int arlan_exit_debug;
> +static int arlan_entry_and_exit_debug;
> +module_param(arlan_entry_debug, bool, 0644);
> +module_param(arlan_exit_debug, bool, 0644);
> +module_param(arlan_entry_and_exit_debug, bool, 0644);
>  MODULE_PARM_DESC(arlan_entry_debug, "Arlan driver function entry debugging");
>  MODULE_PARM_DESC(arlan_exit_debug, "Arlan driver function exit debugging");
>  MODULE_PARM_DESC(arlan_entry_and_exit_debug, "Arlan driver function entry and exit debugging");
> -#else
> -MODULE_PARM_DESC(arlan_entry_debug, "(ignored)");
> -MODULE_PARM_DESC(arlan_exit_debug, "(ignored)");
> -MODULE_PARM_DESC(arlan_entry_and_exit_debug, "(ignored)");
>  #endif
>  
>  struct arlan_conf_stru arlan_conf[MAX_ARLANS];


-- 
~Randy
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

  reply	other threads:[~2004-11-09 21:41 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-11-09 21:32 [KJ] [PATCH] convert arlan wireless driver to module_param Stefan Sperling
2004-11-09 21:41 ` Randy.Dunlap [this message]
2004-11-09 22:07 ` Stefan Sperling

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4191397A.9070907@osdl.org \
    --to=rddunlap@osdl.org \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.