Re: [RFC] Event Cache per-cpu

[Pablo Neira <pablo@eurodev.net>]

Harald Welte wrote:

>On Mon, Nov 08, 2004 at 08:29:38PM +0100, Pablo Neira wrote:
>  
>
>>Hi all,
>>c) per packet cache. I don't see any possible race with this approach at 
>>the moment, but I'll need to use the nfcache field in skbuff. I prefer 
>>this than adding a new field to a skbuff, I think that Davem won't like 
>>that.
>>    
>>
>
>seems fine to me.
>  
>

tony the tiger says grrrreat :)

>>There's 15 bits in nfcache available now (because IPVS guys are using 
>>one in private). My last patch has 11 events.
>>    
>>
>
>who authorized IPVS people to use that bit ? It's ours, and we fought
>hard for it  ;)  [just kidding, but I didn't know that before].
>  
>

I'll sync this between IPVS and netfilter. Make them move that to 
netfilter.h if they really need it. We'll see, later.

>>enum ip_conntrack_events
>>{
>>      IPCT_NEW,                       /* New conntrack                */
>>      IPCT_RELATED,                   /* Expected connection          */
>>      IPCT_DESTROY,                   /* Destroyed conntrack          */
>>      IPCT_STATUS,                    /* Status has changed           */
>>      IPCT_REFRESH,                   /* Timer has been refreshed     */
>>      IPCT_PROTOINFO,                 /* Update of protocol info      */
>>      IPCT_PROTOINFO_VOLATILE,        /* Volatile protocol info       */
>>      IPCT_HELPER,                    /* New helper for conntrack     */
>>      IPCT_HELPINFO,                  /* Update of helper info        */
>>      IPCT_HELPINFO_VOLATILE,         /* Volatile helper info         */
>>      IPCT_NATINFO,                   /* NAT info                     */
>>};
>>
>>Patrick suggests that we could run out of bits soon if events go in 
>>nfcache, that's true. To fix that, could we remove this stuff in 
>>netfilter_ipv4.h, nobody is using it ?
>>    
>>
>
>No, I think this can be removed, nobody has ever used nfcache the way it
>was originally intended.
>  
>

Ok, expect a new patch in next days.

Pablo