Re: ctnetlink & helper_locking_fix conflict

[Pablo Neira <pablo@eurodev.net>]

Harald Welte wrote:

>On Tue, Nov 09, 2004 at 08:13:33AM +0100, Henrik Nordstrom wrote:
>  
>
>>Hi,
>>
>>there is a conflict between the above two patches. The helper_locking_fix 
>>removes the locks from the helpers, but ctnetlink adds code using these 
>>locks.
>>
>>>From reading the code I think the helper side locking should be removed 
>>from the ctnetlink additions as well, but just wanted to verify with you.
>>    
>>
>
>I think it is safe.  We're holding a write lock on ip_conntrack_lock and
>thus it's safe to change the helper data.
>
>If you have a fix for ctnetlink, that would be appreciated
>  
>

I think that there's a minor race. In ip_conntrack_in()

855                 ret = ct->helper->help(*pskb, ct, ctinfo)

This call isn't in a locked section. Someone could be calling the helper 
at the same time that ctnetlink is modifying the private helper info. 
I've annotated this issue since I'll be working in that code (change 
API) once I've done with the event stuff.

Pablo