From: Ross Kendall Axe <ross.axe@blueyonder.co.uk>
To: netdev@oss.sgi.com
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] linux 2.9.10-rc1: Fix oops in unix_dgram_sendmsg when using SELinux and SOCK_SEQPACKET
Date: Sun, 14 Nov 2004 18:13:11 +0000 [thread overview]
Message-ID: <4197A037.1020307@blueyonder.co.uk> (raw)
[-- Attachment #1: Type: text/plain, Size: 889 bytes --]
With CONFIG_SECURITY_NETWORK=y and CONFIG_SECURITY_SELINUX=y, using
SOCK_SEQPACKET unix domain sockets causes an oops in the superfluous(?)
call to security_unix_may_send in sock_dgram_sendmsg. This patch avoids
making this call for SOCK_SEQPACKET sockets.
Signed-off-by: Ross Axe <ross.axe@blueyonder.co.uk>
--- linux-2.6.10-rc1/net/unix/af_unix.c.orig 2004-11-13
21:04:53.000000000 +0000
+++ linux-2.6.10-rc1/net/unix/af_unix.c 2004-11-13 21:12:23.000000000 +0000
@@ -1354,9 +1354,11 @@ restart:
if (other->sk_shutdown & RCV_SHUTDOWN)
goto out_unlock;
- err = security_unix_may_send(sk->sk_socket, other->sk_socket);
- if (err)
- goto out_unlock;
+ if (sk->sk_type != SOCK_SEQPACKET) {
+ err = security_unix_may_send(sk->sk_socket, other->sk_socket);
+ if (err)
+ goto out_unlock;
+ }
if (unix_peer(other) != sk &&
(skb_queue_len(&other->sk_receive_queue) >
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 256 bytes --]
next reply other threads:[~2004-11-14 18:13 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-14 18:13 Ross Kendall Axe [this message]
2004-11-15 13:31 ` [PATCH] linux 2.9.10-rc1: Fix oops in unix_dgram_sendmsg when using SELinux and SOCK_SEQPACKET Stephen Smalley
2004-11-16 8:41 ` Chris Wright
2004-11-17 21:29 ` Ross Kendall Axe
2004-11-18 0:09 ` Ross Kendall Axe
2004-11-18 3:42 ` James Morris
2004-11-18 4:25 ` James Morris
2004-11-18 6:07 ` Chris Wright
2004-11-18 7:25 ` Ross Kendall Axe
2004-11-18 7:59 ` James Morris
2004-11-18 8:27 ` James Morris
2004-11-18 16:44 ` Chris Wright
2004-11-18 17:01 ` James Morris
2004-11-18 17:07 ` Chris Wright
2004-11-18 17:11 ` James Morris
2004-11-18 17:25 ` James Morris
2004-11-18 16:58 ` Alan Cox
2004-11-18 22:34 ` David S. Miller
2004-11-19 3:23 ` Ross Kendall Axe
2004-11-19 7:19 ` Chris Wright
2004-11-19 9:40 ` Ross Kendall Axe
2004-11-19 13:05 ` Arnaldo Carvalho de Melo
2004-11-19 13:16 ` Arnaldo Carvalho de Melo
2004-11-18 16:49 ` Alan Cox
2004-11-18 18:40 ` James Morris
2004-11-18 23:39 ` Alan Cox
2004-11-19 3:12 ` James Morris
2004-11-19 7:01 ` Chris Wright
2004-11-19 7:12 ` James Morris
2004-11-19 7:28 ` Chris Wright
2004-11-19 11:39 ` Alan Cox
2004-11-19 16:24 ` James Morris
2004-11-20 7:11 ` David S. Miller
2004-11-18 16:45 ` Alan Cox
2004-11-18 18:28 ` James Morris
2004-11-18 18:34 ` Chris Wright
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4197A037.1020307@blueyonder.co.uk \
--to=ross.axe@blueyonder.co.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.