All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jan Dittmer <jdittmer@ppp0.net>
To: johnpol@2ka.mipt.ru
Cc: Linux kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] matrox w1: fix integer to pointer conversion warnings
Date: Sun, 14 Nov 2004 21:15:42 +0100	[thread overview]
Message-ID: <4197BCEE.1080409@ppp0.net> (raw)
In-Reply-To: <20041114230617.5ce14ce9@zanzibar.2ka.mipt.ru>

[-- Attachment #1: Type: text/plain, Size: 257 bytes --]

Evgeniy Polyakov wrote:
> On Sun, 14 Nov 2004 13:07:08 +0100
> Jan Dittmer <jdittmer@ppp0.net> wrote:
> 
> 
>>Get rid of some pointer to integer conversion warnings
>>in the matrox w1 bus driver.
> 

You mean like this? (Incremental to the other one)

Jan


[-- Attachment #2: w1.diff --]
[-- Type: text/x-patch, Size: 636 bytes --]

===== matrox_w1.c 1.4 vs edited =====
--- 1.4/drivers/w1/matrox_w1.c	2004-11-14 13:02:18 +01:00
+++ edited/matrox_w1.c	2004-11-14 21:15:09 +01:00
@@ -78,12 +78,12 @@
 
 struct matrox_device
 {
-	char *base_addr;
-	char *port_index, *port_data;
+	char __iomem *base_addr;
+	char __iomem *port_index, *port_data;
 	u8 data_mask;
 
 	unsigned long phys_addr;
-	char *virt_addr;
+	char __iomem *virt_addr;
 	unsigned long found;
 
 	struct w1_bus_master *bus_master;
@@ -227,7 +227,7 @@
 
 	if (dev->found) {
 		w1_remove_master_device(dev->bus_master);
-		iounmap((void *) dev->virt_addr);
+		iounmap(dev->virt_addr);
 	}
 	kfree(dev);
 }

  reply	other threads:[~2004-11-14 20:16 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-11-14 12:07 [PATCH] matrox w1: fix integer to pointer conversion warnings Jan Dittmer
2004-11-14 20:06 ` Evgeniy Polyakov
2004-11-14 20:15   ` Jan Dittmer [this message]
2004-11-15  4:43     ` Evgeniy Polyakov
2004-11-15  4:46       ` Roland Dreier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4197BCEE.1080409@ppp0.net \
    --to=jdittmer@ppp0.net \
    --cc=johnpol@2ka.mipt.ru \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.