From: Thomas Monjalon <thomas@monjalon.net>
To: Matan Azrad <matan@mellanox.com>
Cc: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"Gaëtan Rivet" <gaetan.rivet@6wind.com>
Subject: Re: [PATCH v7 0/3] failsafe: fix hotplug races
Date: Tue, 13 Feb 2018 22:21:32 +0100 [thread overview]
Message-ID: <4199780.l4afLUpUQf@xps> (raw)
In-Reply-To: <AM4PR0501MB2657CF518AF48B15F1AAF0A9D2F60@AM4PR0501MB2657.eurprd05.prod.outlook.com>
13/02/2018 22:13, Matan Azrad:
> From: De Lara Guarch, Pablo [mailto:pablo.de.lara.guarch@intel.com]
> > There is a compilation error due to this patch on FreeBSD:
> >
> > drivers/net/failsafe/failsafe_private.h:377:53: error: format specifies type
> > 'unsigned long' but the argument has type 'pthread_t' (aka 'struct pthread *')
> > [-Werror,-Wformat]
> > DEBUG("Hot-plug mutex was locked by thread %lu%s", pthread_self(),
> >
> >
> > I am not sure how to print a pthread_t, so I can just report the issue.
> >
> Can you check with (unsigned long int) conversion?
On FreeBSD, pthread_t is:
typedef struct pthread *pthread_t;
pthread_t is not portable and should not be printed.
I am preparing a patch to enable pthread_t debugging only in Linux.
prev parent reply other threads:[~2018-02-13 21:21 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-09 19:27 [PATCH] net/failsafe: fix calling device during RMV events Ophir Munk
2017-09-11 8:31 ` Gaëtan Rivet
2017-09-23 21:57 ` Ophir Munk
2017-10-05 22:42 ` [PATCH v3] " Ophir Munk
2017-10-20 10:35 ` Gaëtan Rivet
2017-10-23 7:17 ` Ophir Munk
2017-10-23 8:36 ` Gaëtan Rivet
2017-11-29 19:17 ` [dpdk-stable] " Ferruh Yigit
2018-01-18 22:22 ` Thomas Monjalon
2018-01-18 23:35 ` Gaëtan Rivet
2018-02-08 12:20 ` [PATCH v4 0/2] failsafe: " Matan Azrad
2018-02-08 12:20 ` [PATCH v4 1/2] net/failsafe: fix hotplug alarm cancel Matan Azrad
2018-02-08 12:20 ` [PATCH v4 2/2] net/failsafe: fix calling device during RMV events Matan Azrad
2018-02-08 16:34 ` [PATCH v5 0/3] failsafe: " Matan Azrad
2018-02-08 16:34 ` [PATCH v5 1/3] net/failsafe: fix hotplug alarm cancel Matan Azrad
2018-02-08 16:34 ` [PATCH v5 2/3] net/failsafe: fix removal scope Matan Azrad
2018-02-08 17:19 ` Gaëtan Rivet
2018-02-08 19:03 ` Matan Azrad
2018-02-08 16:34 ` [PATCH v5 3/3] net/failsafe: fix calling device during RMV events Matan Azrad
2018-02-08 18:11 ` Gaëtan Rivet
2018-02-08 19:24 ` Matan Azrad
2018-02-11 17:24 ` [PATCH v6 0/3] failsafe: fix hotplug races Matan Azrad
2018-02-11 17:24 ` [PATCH v6 1/3] net/failsafe: fix hotplug alarm cancel Matan Azrad
2018-02-11 17:24 ` [PATCH v6 2/3] net/failsafe: fix removal scope Matan Azrad
2018-02-11 17:24 ` [PATCH v6 3/3] net/failsafe: fix hotplug races Matan Azrad
2018-02-12 18:33 ` Gaëtan Rivet
2018-02-12 20:35 ` Matan Azrad
2018-02-12 20:51 ` [PATCH v7 0/3] failsafe: " Matan Azrad
2018-02-12 20:51 ` [PATCH v7 1/3] net/failsafe: fix hotplug alarm cancel Matan Azrad
2018-02-12 20:51 ` [PATCH v7 2/3] net/failsafe: fix removal scope Matan Azrad
2018-02-12 20:51 ` [PATCH v7 3/3] net/failsafe: fix hotplug races Matan Azrad
2018-02-13 13:31 ` [PATCH v7 0/3] failsafe: " Gaëtan Rivet
2018-02-13 16:12 ` Thomas Monjalon
2018-02-13 20:58 ` De Lara Guarch, Pablo
2018-02-13 21:13 ` Matan Azrad
2018-02-13 21:21 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4199780.l4afLUpUQf@xps \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=gaetan.rivet@6wind.com \
--cc=matan@mellanox.com \
--cc=pablo.de.lara.guarch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.