All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jgarzik@pobox.com>
To: James Bottomley <James.Bottomley@steeleye.com>
Cc: SCSI Mailing List <linux-scsi@vger.kernel.org>,
	Andrew Morton <akpm@osdl.org>
Subject: Re: SCSI breaks 'make allyesconfig'
Date: Wed, 17 Nov 2004 09:05:22 -0500	[thread overview]
Message-ID: <419B5AA2.7030801@pobox.com> (raw)
In-Reply-To: <419B5292.7080305@pobox.com>

[-- Attachment #1: Type: text/plain, Size: 678 bytes --]

Jeff Garzik wrote:
> [jgarzik@pretzel linux-2.6]$ make
>   CHK     include/linux/version.h
> make[1]: `arch/i386/kernel/asm-offsets.s' is up to date.
>   CHK     include/linux/compile.h
>   CHK     usr/initramfs_list
>   LD      drivers/scsi/built-in.o
> drivers/scsi/osst.o(.bss+0x0): In function `exit_osst':
> drivers/scsi/osst.c:195: multiple definition of `ST_partstat'
> drivers/scsi/st.o(.bss+0x0):drivers/scsi/st.c:244: first defined here
> make[2]: *** [drivers/scsi/built-in.o] Error 1
> make[1]: *** [drivers/scsi] Error 2
> make: *** [drivers] Error 2


  ...and the attached patch fixes it.  'ST_partstat' is defined in 
drivers/scsi/st.h, but never used.

	Jeff



[-- Attachment #2: patch --]
[-- Type: text/plain, Size: 326 bytes --]

===== drivers/scsi/st.h 1.20 vs edited =====
--- 1.20/drivers/scsi/st.h	2004-10-25 14:32:30 -04:00
+++ edited/drivers/scsi/st.h	2004-11-17 08:36:22 -05:00
@@ -67,7 +67,7 @@
 	u32 last_block_visited;
 	int drv_block;		/* The block where the drive head is */
 	int drv_file;
-} ST_partstat;
+};
 
 #define ST_NBR_PARTITIONS 4
 

  reply	other threads:[~2004-11-17 14:05 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-11-17 13:30 SCSI breaks 'make allyesconfig' Jeff Garzik
2004-11-17 14:05 ` Jeff Garzik [this message]
2004-11-17 16:21   ` James Bottomley
2004-11-17 14:05 ` Matthew Wilcox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=419B5AA2.7030801@pobox.com \
    --to=jgarzik@pobox.com \
    --cc=James.Bottomley@steeleye.com \
    --cc=akpm@osdl.org \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.