From: "Randy.Dunlap" <rddunlap@osdl.org>
To: Oleg Nesterov <oleg@tv-sign.ru>
Cc: linux-kernel@vger.kernel.org, Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH] trivial, uninline do_trap(), remove get_cr2()
Date: Wed, 17 Nov 2004 09:12:59 -0800 [thread overview]
Message-ID: <419B869B.5030603@osdl.org> (raw)
In-Reply-To: <419B64C2.CED2FABC@tv-sign.ru>
Oleg Nesterov wrote:
> Uninlining do_trap() saves 544 bytes in traps.o.
> get_cr2() seems to be unused, remove it.
>
> Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>
>
> --- 2.6.10-rc2/arch/i386/kernel/traps.c~ Tue Nov 16 14:13:08 2004
> +++ 2.6.10-rc2/arch/i386/kernel/traps.c Wed Nov 17 16:47:41 2004
> @@ -358,16 +358,7 @@ static inline void die_if_kernel(const c
> die(str, regs, err);
> }
>
> -static inline unsigned long get_cr2(void)
> -{
> - unsigned long address;
> -
> - /* get the address */
> - __asm__("movl %%cr2,%0":"=r" (address));
> - return address;
> -}
Looks like it can be removed from arch/x86_64/kernel/traps.c also.
--
~Randy
prev parent reply other threads:[~2004-11-17 17:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-17 14:48 [PATCH] trivial, uninline do_trap(), remove get_cr2() Oleg Nesterov
2004-11-17 17:12 ` Randy.Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=419B869B.5030603@osdl.org \
--to=rddunlap@osdl.org \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@tv-sign.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.