[PATCH] oops on boot when initializing CDROM

["Randy.Dunlap" <rddunlap@osdl.org>]

[-- Attachment #1: Type: text/plain, Size: 484 bytes --]

Mikulas Patocka wrote:
> When booting kernel 2.4.27 on notebook with cd-rw dvd-ro drive, I get oops
> on cdrom_sysctl_register+2a trying to dereference address 20.
> Call stack: register_cdrom+235
> 
> gcc-3.2.3

Thanks for the .config file.

with: CONFIG_SYSCTL=y, CONFIG_PROC_FS=n

Am I confused here, or is the 2.4 (and 2.6) source code confused?


diffstat:=
  drivers/cdrom/cdrom.c |    2 --
  1 files changed, 2 deletions(-)

Signed-off-by: Randy Dunlap <rddunlap@osdl.org>
-- 

[-- Attachment #2: cdrom_sysctl_24.patch --]
[-- Type: text/x-patch, Size: 522 bytes --]

diff -Naurp ./drivers/cdrom/cdrom.c~cdrom_sysctl ./drivers/cdrom/cdrom.c
--- ./drivers/cdrom/cdrom.c~cdrom_sysctl	2003-11-28 10:26:20.000000000 -0800
+++ ./drivers/cdrom/cdrom.c	2004-11-17 10:45:45.666804288 -0800
@@ -2598,9 +2598,7 @@ ctl_table cdrom_cdrom_table[] = {
 
 /* Make sure that /proc/sys/dev is there */
 ctl_table cdrom_root_table[] = {
-#ifdef CONFIG_PROC_FS
 	{CTL_DEV, "dev", NULL, 0, 0555, cdrom_cdrom_table},
-#endif /* CONFIG_PROC_FS */
 	{0}
 	};
 static struct ctl_table_header *cdrom_sysctl_header;