From mboxrd@z Thu Jan  1 00:00:00 1970
From: Laurent Riffard <laurent.riffard@free.fr>
Subject: [PATCH] reiser4: fix a use after free bug in reiser4_parse_options
Date: Thu, 18 Nov 2004 00:09:36 +0100
Message-ID: <419BDA30.20707@free.fr>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
 protocol="application/pgp-signature";
 boundary="------------enigD23E6B6BE63CFF23DB5BA72B"
Return-path: <reiserfs-list-return-22402-reiserfs=m.gmane.org@namesys.com>
list-help: <mailto:reiserfs-list-help@namesys.com>
list-unsubscribe: <mailto:reiserfs-list-unsubscribe@namesys.com>
list-post: <mailto:reiserfs-list@namesys.com>
Errors-To: flx@namesys.com
List-Id: <reiserfs-devel.vger.kernel.org>
To: reiserfs-list@namesys.com

--------------enigD23E6B6BE63CFF23DB5BA72B
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit

This patch fix a "use after kfree" bug in reiser4_parse_options.

Signed-off-by: Laurent Riffard <laurent.riffard@free.fr>
---

diff -u linux-2.6-orig/fs/reiser4/vfs_ops.c linux-2.6/fs/reiser4/vfs_ops.c
--- linux-2.6-orig/fs/reiser4/vfs_ops.c	2004-11-17 23:43:22.186242952 +0100
+++ linux-2.6/fs/reiser4/vfs_ops.c	2004-11-17 23:39:15.935678728 +0100
@@ -1060,8 +1060,6 @@
 	});
 #endif
 
-	kfree(opts);
-
 	sbinfo->tmgr.atom_max_size = txnmgr_get_max_atom_size(s);
 	sbinfo->tmgr.atom_max_age = REISER4_ATOM_MAX_AGE / HZ;
 	sbinfo->tmgr.atom_max_flushers = ATOM_MAX_FLUSHERS;
@@ -1089,6 +1087,9 @@
 	sbinfo->ra_params.flags = 0;
 
 	result = parse_options(opt_string, opts, p - opts);
+
+	kfree(opts);
+
 	if (result != 0)
 		return result;
 

-- 
laurent


--------------enigD23E6B6BE63CFF23DB5BA72B
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFBm9o5UqUFrirTu6IRAsrNAJ47Aoeyh1PsKYhYlX1sv9m/rEnxRQCdHE9R
0Jz0aCr2850MGYGJbrnUkM4=
=YOL8
-----END PGP SIGNATURE-----

--------------enigD23E6B6BE63CFF23DB5BA72B--