From: "Steffen A. Mork" <linux-dev@morknet.de>
To: Tonnerre <tonnerre@thundrix.ch>
Cc: "Steffen A. Mork" <linux-dev@morknet.de>,
linux-kernel@vger.kernel.org, trivial@rustcorp.com.au,
torvalds@osdl.org
Subject: Re: [PATCH] dss1_divert ISDN module compile fix for kernel 2.6.8.1
Date: Thu, 18 Nov 2004 06:53:35 +0100 [thread overview]
Message-ID: <419C38DF.1050802@morknet.de> (raw)
In-Reply-To: <20041117224315.GA2198@pauli.thundrix.ch>
> Salut,
Hallo,
> On Wed, Nov 17, 2004 at 03:54:37PM +0100, Steffen A. Mork wrote:
>
>>http://ls7-www.cs.uni-dortmund.de/~mork/dss1_divert.diff
>
>
> This patch is wrong. You're using a spinlock you declare on the stack
> of a function, so it's completely pointless.
You are right. I've corrected my mistake already. Look at
http://ls7-www.cs.uni-dortmund.de/~mork/dss1_divert-patch1-2-patch2.diff
to correct that patch or
http://ls7-www.cs.uni-dortmund.de/~mork/dss1_divert-patch2.diff
for the complete correct patch.
> Please look at http://users.thundrix.ch/~tonnerre/kernel/2.6.1-tch1/
> where I gathered lots of ISDN patches a while ago. It might be a start
> for you.
Thank you.
> Tonnerre
Steffen
next prev parent reply other threads:[~2004-11-18 5:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-17 14:54 [PATCH] dss1_divert ISDN module compile fix for kernel 2.6.8.1 Steffen A. Mork
2004-11-17 16:28 ` Bartlomiej Zolnierkiewicz
2004-11-17 16:55 ` Linus Torvalds
2004-11-17 18:52 ` Steffen A. Mork
2004-11-17 20:07 ` Bartlomiej Zolnierkiewicz
2004-11-17 21:14 ` Steffen A. Mork
2004-11-17 16:39 ` Jan Engelhardt
2004-11-17 22:43 ` [PATCH] " Tonnerre
2004-11-18 5:53 ` Steffen A. Mork [this message]
2004-11-18 5:57 ` Tonnerre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=419C38DF.1050802@morknet.de \
--to=linux-dev@morknet.de \
--cc=linux-kernel@vger.kernel.org \
--cc=tonnerre@thundrix.ch \
--cc=torvalds@osdl.org \
--cc=trivial@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.