From: Corey Minyard <cminyard@mvista.com>
To: Andi Kleen <ak@suse.de>
Cc: linux-kernel@vger.kernel.org, akpm@osdl.org
Subject: Re: [PATCH} Network interface for IPMI
Date: Thu, 18 Nov 2004 08:09:29 -0600 [thread overview]
Message-ID: <419CAD19.4030203@mvista.com> (raw)
In-Reply-To: <p73oehv22oz.fsf@brahms.suse.de>
Ok, I agree. You are right, at least the ioctls can be fixed up.
-Corey
Andi Kleen wrote:
>Corey Minyard <cminyard@mvista.com> writes:
>
>
>
>>I have decided
>>that the network interface for IPMI is a good thing, as the IPMI
>>device ioctls have pointers and require ugly hacks. None should be
>>needed for the network interface.
>>
>>
>
>That's a joke, right?
>
>
>
>
>>+struct ipmi_sock_msg {
>>+ int recv_type;
>>+ long msgid;
>>
>>
> ^^^^^^^^^^^
>
>Of course long would need to be always emulated. Your patch
>shows exactly why packet based protocols for this are a bad
>idea. The problem is that people will get it wrong, and then
>it's nearly impossible to fix for a socket based protocol
>because read/write cannot be easily hooked
>(with ipsec we have exactly this problem already)
>
>ioctls at least can be fixed up. Please keep using them.
>
>
>
>>+ int data_len;
>>+ unsigned char data[0];
>>
>>
>
>And I don't even want to know what's in there.
>
>Andrew, please don't apply this broken patch.
>
>-Andi
>
>
>
next prev parent reply other threads:[~2004-11-18 14:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <31Fe2-5kB-11@gated-at.bofh.it>
2004-11-18 4:36 ` [PATCH} Network interface for IPMI Andi Kleen
2004-11-18 14:09 ` Corey Minyard [this message]
2004-11-17 20:36 Corey Minyard
2004-11-17 20:51 ` Andrew Morton
2004-11-17 21:19 ` Corey Minyard
2004-11-17 22:12 ` Corey Minyard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=419CAD19.4030203@mvista.com \
--to=cminyard@mvista.com \
--cc=ak@suse.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.