From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sc8-sf-mx2-b.sourceforge.net ([10.3.1.12] helo=sc8-sf-mx2.sourceforge.net) by sc8-sf-list1.sourceforge.net with esmtp (Exim 4.30) id 1CUojF-0007sA-I0 for user-mode-linux-devel@lists.sourceforge.net; Thu, 18 Nov 2004 08:01:49 -0800 Received: from plam.fujitsu-siemens.com ([217.115.66.9]) by sc8-sf-mx2.sourceforge.net with esmtp (Exim 4.41) id 1CUojC-0000jw-DI for user-mode-linux-devel@lists.sourceforge.net; Thu, 18 Nov 2004 08:01:49 -0800 Message-ID: <419CC762.8070602@fujitsu-siemens.com> From: Bodo Stroesser MIME-Version: 1.0 Subject: Re: [uml-devel] Patchset to implement PTRACE_SYSEMU_SINGLESTEP References: <419517A4.7020700@fujitsu-siemens.com> <200411180647.iAI6lSQ3008451@ccure.user-mode-linux.org> <419CAF81.9010408@fujitsu-siemens.com> <200411181541.13171.blaisorblade_spam@yahoo.it> In-Reply-To: <200411181541.13171.blaisorblade_spam@yahoo.it> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Sender: user-mode-linux-devel-admin@lists.sourceforge.net Errors-To: user-mode-linux-devel-admin@lists.sourceforge.net List-Unsubscribe: , List-Id: The user-mode Linux development list List-Post: List-Help: List-Subscribe: , List-Archive: Date: Thu, 18 Nov 2004 17:01:38 +0100 To: Blaisorblade Cc: user-mode-linux-devel@lists.sourceforge.net, Jeff Dike Blaisorblade wrote: > On Thursday 18 November 2004 15:19, Bodo Stroesser wrote: > >>Jeff Dike wrote: >> >>>bstroesser@fujitsu-siemens.com said: >>> >>>>What happens on my system shows some other symptoms. After "Restarting >>>>system." UML exits without further message. I could track this down to >>>>a SIGIO being unblocked immediately before the execvp(). It is handled >>>>by sig_handler() that calls sig_handler_common_skas(). Why this exits, >>>>I don't know. > > >>>Try this patch. It adds the missing closes that you found today, plus it >>>makes sure that netdevices get closed down correctly. > > >>> Jeff > > >>Yes. I've tested and mostly it works fine. Only one litte change is needed >>to have the daemon-network working after "network stop" and "network >>start". I commented it in the patch. > > You mean restarting network support in the guest, right? Yes. There were some problems in reboot related to the way, daemon network was closed on "network stop" while UML shutdown. > > >> Bodo > > >>>Index: 2.6.9/arch/um/drivers/net_kern.c >>>=================================================================== >>>--- 2.6.9.orig/arch/um/drivers/net_kern.c 2004-11-17 22:25:19.000000000 >>>-0500 +++ 2.6.9/arch/um/drivers/net_kern.c 2004-11-17 23:18:21.000000000 >>>-0500 @@ -126,10 +126,6 @@ >>> lp->tl.data = (unsigned long) &lp->user; >>> netif_start_queue(dev); >>> >>>- spin_lock(&opened_lock); >>>- list_add(&lp->list, &opened); >>>- spin_unlock(&opened_lock); >>>- >>> /* clear buffer - it can happen that the host side of the interface >>> * is full when we get here. In this case, new data is never queued, >>> * SIGIOs never arrive, and the net never works. >>>@@ -150,11 +146,10 @@ >>> >>> free_irq_by_irq_and_dev(dev->irq, dev); > > >>A little question: what about the "free_irq_by_irq_and_dev"? In my sources >>they are missing, and I couldn't find a patch relating this. My daemon >>works without it. > > > Use the 2.6.10-rc2 tree and you should find that - it's an update for IRQ > handling changes in 2.6.10, i.e. the creation of generic IRQ support, in > kernel/irq/*, merged by Ingo Molnar. Aha! I'm still using 2.6.9-bb2 plus some of my patches. > > From arch/i386/kernel/irq.c: > > /* > * (mostly architecture independent, will move to kernel/irq.c in 2.5.) > */ > Well, Ingo Molnar did this. Other archs are not forced to upgrade to the new > code, but UML was borrowing the i386 headers, which got converted, so we had > no choice. ------------------------------------------------------- This SF.Net email is sponsored by: InterSystems CACHE FREE OODBMS DOWNLOAD - A multidimensional database that combines robust object and relational technologies, making it a perfect match for Java, C++,COM, XML, ODBC and JDBC. www.intersystems.com/match8 _______________________________________________ User-mode-linux-devel mailing list User-mode-linux-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel