From: Hans Reiser <reiser@namesys.com>
To: Jesper Juhl <juhl-lkml@dif.dk>
Cc: lkml <linux-kernel@vger.kernel.org>, vs <vs@thebsh.namesys.com>
Subject: Re: [patch] silence sparse warning in fs/reiserfs/namei.c about using plain integer as NULL pointer
Date: Mon, 22 Nov 2004 07:59:54 -0800 [thread overview]
Message-ID: <41A20CFA.3050101@namesys.com> (raw)
In-Reply-To: <Pine.LNX.4.61.0411212304180.3423@dragon.hygekrogen.localhost>
Jesper Juhl wrote:
>Hi,
>
>sparse complains about passing 0 to functions execting a pointer argument:
>
> CHECK fs/reiserfs/namei.c
>fs/reiserfs/namei.c:617:50: warning: Using plain integer as NULL pointer
>
>Trivial patch to change it to pass NULL instead below.
>
>Signed-off-by: Jesper Juhl <juhl-lkml@dif.dk>
>
>diff -up linux-2.6.10-rc2-bk6-orig/fs/reiserfs/namei.c linux-2.6.10-rc2-bk6/fs/reiserfs/namei.c
>--- linux-2.6.10-rc2-bk6-orig/fs/reiserfs/namei.c 2004-11-17 01:20:16.000000000 +0100
>+++ linux-2.6.10-rc2-bk6/fs/reiserfs/namei.c 2004-11-21 22:52:41.000000000 +0100
>@@ -614,7 +614,7 @@ static int reiserfs_create (struct inode
> goto out_failed;
> }
>
>- retval = reiserfs_new_inode (&th, dir, mode, 0, 0/*i_size*/, dentry, inode);
>+ retval = reiserfs_new_inode (&th, dir, mode, NULL, 0/*i_size*/, dentry, inode);
> if (retval)
> goto out_failed;
>
>
>
>
>
>
>
thanks, vs. will look into it and get back to you.
prev parent reply other threads:[~2004-11-23 4:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-21 22:08 [patch] silence sparse warning in fs/reiserfs/namei.c about using plain integer as NULL pointer Jesper Juhl
2004-11-22 15:59 ` Hans Reiser [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41A20CFA.3050101@namesys.com \
--to=reiser@namesys.com \
--cc=juhl-lkml@dif.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=vs@thebsh.namesys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.