Re: [PATCH 2/5] selinux: adds a private inode operation

[Jeff Mahoney <jeffm@suse.com>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Stephen Smalley wrote:
| On Mon, 2004-11-22 at 13:04, Jeff Mahoney wrote:
|
|>Yes, you're right. The isec->initialized check means that code never
|>gets executed.
|
|
| Ok.  How about the untested diff below relative to your patch?  It
| removes the unnecessary code, replaces the unused inherits flag field
| (legacy from earlier code) with a private flag field, does not set the
| SID in selinux_inode_mark_private (leaving it with the unlabeled SID,
| which will ensure that we notice it if it ever reaches a SELinux
| permission check), and modifies SELinux permission checking functions
| and post_create() to test for the private flag and skip SELinux
| processing in that case.  Note that this means that reiserfs should be
| able to use the VFS helpers if desired without interference by SELinux
| when accessing these private inodes.
|

Excellent. Thanks. Preliminary testing works as expected (ie: deadlocks
don't occur, xattrs/<dir> is removed when owning file is deleted)

I've integrated the changes into my patch set. With those issues
addressed, would you feel these would be appropriate for inclusion? I
suspect you may have gotten questions as many interested parties in this
feature working as I have.

- -Jeff

- --
Jeff Mahoney
SuSE Labs
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.5 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFBojkiLPWxlyuTD7IRAoM/AJ9XQ/twgcSTiRGQU1kOp01A2NlhywCfWrvF
/LtguPq+tMjFe1uThpR4fws=
=izmO
-----END PGP SIGNATURE-----