All of lore.kernel.org
 help / color / mirror / Atom feed
From: Manish Lachwani <mlachwani@mvista.com>
To: "Maciej W. Rozycki" <macro@linux-mips.org>
Cc: Thomas Koeller <thomas.koeller@baslerweb.com>, linux-mips@linux-mips.org
Subject: Re: titan code question
Date: Mon, 22 Nov 2004 11:42:44 -0800	[thread overview]
Message-ID: <41A24134.8050004@mvista.com> (raw)
In-Reply-To: <Pine.LNX.4.58L.0411221936220.31113@blysk.ds.pg.gda.pl>

Maciej W. Rozycki wrote:
> On Mon, 22 Nov 2004, Manish Lachwani wrote:
> 
> 
>>Hence, they used this register. I am not sure if this is even 
>>documented. However, this code has been written based on the feedback 
>>from the chip designers. If you dont use this code, the MAC subsystem of 
>>titan will stop aligning IP headers and you will need to implement the 
>>code in the driver to do the aligning.
> 
> 
>  That means you should use macros for registers and their contents,
> preferably with some nearby documentation in the form of comments to
> clarify less obvious bits.  Otherwise you end up with an unmaintainable
> mess, especially once other sources of information drain out.
> 
>   Maciej

I agree that we need to provide documentation :)

Thanks
Manish Lachwani

      reply	other threads:[~2004-11-22 19:42 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-11-19 15:23 titan code question Thomas Koeller
2004-11-22 17:35 ` Manish Lachwani
2004-11-22 19:40   ` Maciej W. Rozycki
2004-11-22 19:42     ` Manish Lachwani [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=41A24134.8050004@mvista.com \
    --to=mlachwani@mvista.com \
    --cc=linux-mips@linux-mips.org \
    --cc=macro@linux-mips.org \
    --cc=thomas.koeller@baslerweb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.