From: Brian Haley <Brian.Haley@hp.com>
To: yoshfuji@linux-ipv6.org
Cc: davem@davemloft.net, netdev@oss.sgi.com
Subject: Re: [BK PATCH] [IPV6] Multiple locking fixes/improvements
Date: Tue, 23 Nov 2004 13:09:24 -0500 [thread overview]
Message-ID: <41A37CD4.3030503@hp.com> (raw)
In-Reply-To: <20041122.223205.14979415.yoshfuji@linux-ipv6.org>
YOSHIFUJI Hideaki / 吉藤英明 wrote:
> ChangeSet@1.2232, 2004-11-23 11:52:57+09:00, yoshfuji@linux-ipv6.org
> [IPV6] Fix a race when dad completed during shutting down its owner interface.
> +static void ipv6_ifa_notify(int event, struct inet6_ifaddr *ifp)
> +{
> + read_lock_bh(&addrconf_lock);
> + if (ifp->idev->dead)
> + goto out;
> + __ipv6_ifa_notify(event, ifp);
> +out:
> + read_unlock_bh(&addrconf_lock);
> }
Not to nitpick, but this is just easier to read:
+static void ipv6_ifa_notify(int event, struct inet6_ifaddr *ifp)
+{
+ read_lock_bh(&addrconf_lock);
+ if (!ifp->idev->dead)
+ __ipv6_ifa_notify(event, ifp);
+ read_unlock_bh(&addrconf_lock);
}
-Brian
next prev parent reply other threads:[~2004-11-23 18:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-23 3:32 [BK PATCH] [IPV6] Multiple locking fixes/improvements YOSHIFUJI Hideaki / 吉藤英明
2004-11-23 12:58 ` YOSHIFUJI Hideaki / 吉藤英明
2004-11-23 18:09 ` Brian Haley [this message]
2004-11-23 18:37 ` YOSHIFUJI Hideaki / 吉藤英明
2004-11-30 3:23 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41A37CD4.3030503@hp.com \
--to=brian.haley@hp.com \
--cc=davem@davemloft.net \
--cc=netdev@oss.sgi.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.