From: Timur Tabi <timur.tabi@ammasso.com>
To: Jesper Juhl <juhl-lkml@dif.dk>
Cc: linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Remove pointless <0 comparison for unsigned variable in fs/fcntl.c
Date: Tue, 23 Nov 2004 17:03:10 -0600 [thread overview]
Message-ID: <41A3C1AE.5060604@ammasso.com> (raw)
In-Reply-To: <Pine.LNX.4.61.0411240003300.3389@dragon.hygekrogen.localhost>
Jesper Juhl wrote:
> if pid_t is 16 bit, then the value can never be greater than 0xffff but,
> if pid_t is greater than 16 bit, say 32 bit, then the argument "a" could
> very well contain a value greater than 0xffff and then the comparison
> makes perfect sense.
If pid_t is 32-bit, then what's wrong with the value being greater than
0xFFFF? After all, if pid_t a 32-bit number, that implies that 32-bit
values are acceptable.
--
Timur Tabi
Staff Software Engineer
timur.tabi@ammasso.com
next prev parent reply other threads:[~2004-11-23 23:09 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-21 22:55 [PATCH] Remove pointless <0 comparison for unsigned variable in fs/fcntl.c Jesper Juhl
2004-11-22 1:02 ` Matthew Wilcox
2004-11-23 9:42 ` Jesper Juhl
2004-11-23 10:42 ` Jamie Lokier
2004-11-23 18:28 ` Bryan Henderson
2004-11-23 18:03 ` Linus Torvalds
2004-11-23 18:39 ` Jesper Juhl
2004-11-23 18:37 ` Linus Torvalds
2004-11-23 19:20 ` linux-os
2004-11-23 23:16 ` Jesper Juhl
2004-11-23 19:13 ` Timur Tabi
2004-11-23 23:09 ` Jesper Juhl
2004-11-23 23:03 ` Timur Tabi [this message]
2004-11-23 23:19 ` Jesper Juhl
2004-11-23 23:09 ` Timur Tabi
2004-11-23 23:28 ` Jesper Juhl
2004-11-25 22:34 ` Valdis.Kletnieks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41A3C1AE.5060604@ammasso.com \
--to=timur.tabi@ammasso.com \
--cc=juhl-lkml@dif.dk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.