From: Luiz Fernando Capitulino <lcapitulino@conectiva.com.br>
To: "David S. Miller" <davem@davemloft.net>
Cc: akpm@osdl.org, jgarzik@pobox.com, netdev@oss.sgi.com
Subject: Re: [patch 10/13] net/socket.c::sys_bind() cleanup.
Date: Wed, 24 Nov 2004 08:55:10 -0200 [thread overview]
Message-ID: <41A4688E.80908@conectiva.com.br> (raw)
In-Reply-To: <20041124002709.52cb8d1f.davem@davemloft.net>
David S. Miller wrote:
> On Sun, 21 Nov 2004 22:43:56 -0800
> akpm@osdl.org wrote:
>
>
>>From: "Luiz Fernando N. Capitulino" <lcapitulino@conectiva.com.br>
>>
>>net/socket.c::sys_bind() is a bit complex function, the patch below makes
>>it more clear.
>>
>>Signed-off-by: Luiz Capitulino <lcapitulino@conectiva.com.br>
>>Signed-off-by: Andrew Morton <akpm@osdl.org>
>
>
> This was commented on to be buggy, or at least change behavior.
> The "if (err >= 0)" tests were changed to flat "if (err)" tests.
It doesn't a buggy or change behaivor.
What happens here is that move_addr_to_kernel() returns 0
success and -EINVAL or -EFAULT on error. Thus, change from
"if (err >= 0)" to "if (err)" is safe.
Also, it was discussed and ACK'ed by James Morris:
http://lkml.org/lkml/2004/11/16/339
The real problem here I've made a bad patch
description. I'll try to make it better next time.
thanks,
--
Luiz Fernando N. Capitulino
next prev parent reply other threads:[~2004-11-24 10:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-22 6:43 [patch 10/13] net/socket.c::sys_bind() cleanup akpm
2004-11-24 8:27 ` David S. Miller
2004-11-24 10:55 ` Luiz Fernando Capitulino [this message]
2004-11-24 22:03 ` David Stevens
2004-11-25 10:19 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41A4688E.80908@conectiva.com.br \
--to=lcapitulino@conectiva.com.br \
--cc=akpm@osdl.org \
--cc=davem@davemloft.net \
--cc=jgarzik@pobox.com \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.