From: Manfred Spraul <manfred@colorfullife.com>
To: dipankar@in.ibm.com
Cc: Oleg Nesterov <oleg@tv-sign.ru>,
linux-kernel@vger.kernel.org, Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH 1/2] rcu: cosmetic, delete wrong comment, use HARDIRQ_OFFSET
Date: Sun, 28 Nov 2004 16:24:39 +0100 [thread overview]
Message-ID: <41A9EDB7.8020304@colorfullife.com> (raw)
In-Reply-To: <20041128151925.GA20894@in.ibm.com>
Dipankar Sarma wrote:
>On Sun, Nov 28, 2004 at 06:06:52PM +0300, Oleg Nesterov wrote:
>
>
>>Afaics, this comment is misleading. rcu_check_quiescent_state()
>>is executed in softirq context, while rcu_check_callbacks() checks
>>in_softirq() before ++qsctr.
>>
>>Also, replace (1 << HARDIRQ_SHIFT) by HARDIRQ_OFFSET.
>>
>>
>>
>
>Looks good to me. IIRC, that comment has been around since very
>early prototypes, so it is probably leftover trash.
>
>
>
I agree. I think I only moved it around.
But I don't like the HARDIRQ_OFFSET change. If I understand the code
correctly it checks that there is no hardirq reentrancy, i.e. the count
is 0 or 1. Shifted to the appropriate position for the actual test.
I'd either leave it as it is or use "1*HARDIRQ_OFFSET" - otherwise the
information that the count should be less of equal one is lost.
--
Manfred
next prev parent reply other threads:[~2004-11-28 15:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-28 15:06 [PATCH 1/2] rcu: cosmetic, delete wrong comment, use HARDIRQ_OFFSET Oleg Nesterov
2004-11-28 14:31 ` William Lee Irwin III
2004-11-28 16:06 ` Oleg Nesterov
2004-11-28 15:19 ` Dipankar Sarma
2004-11-28 15:24 ` Manfred Spraul [this message]
2004-11-28 15:42 ` Dipankar Sarma
2004-11-28 17:36 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41A9EDB7.8020304@colorfullife.com \
--to=manfred@colorfullife.com \
--cc=akpm@osdl.org \
--cc=dipankar@in.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@tv-sign.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.