From: Jeff Garzik <jgarzik@pobox.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Al Viro <viro@parcelfarce.linux.theplanet.co.uk>,
Adrian Bunk <bunk@stusta.de>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [2.6 patch] move OSS ac97_codec.h to sound/oss/
Date: Tue, 30 Nov 2004 12:56:04 -0500 [thread overview]
Message-ID: <41ACB434.4030100@pobox.com> (raw)
In-Reply-To: <1101830044.25603.49.camel@localhost.localdomain>
Alan Cox wrote:
> On Maw, 2004-11-30 at 01:37, Al Viro wrote:
>
>>On Tue, Nov 30, 2004 at 02:31:39AM +0100, Adrian Bunk wrote:
>>
>>>As far as I can see, there's no good reason why the OSS ac97_codec.h
>>>lives in include/linux/ .
>>
>>Except for a bunch of constants defined there. Are you sure that they
>>are not exposed to userland?
>
>
> OSS never really exposed raw AC97 to user space. Probably it should have
> for the whacky corner cases and for stuff like AC97 digitizers.
>
> Acked-by: Alan Cox <alan@redhat.com>
Disagreement-from: Jeff Garzik <jgarzik@pobox.com>
The reason why ac97_codec.h is in include/linux is because it provides a
__public interface__.
Adrian's change
(a) makes it difficult to work on OSS drivers outside sound/oss
(b) increases the pain level of keeping 2.4 and 2.6 drivers in sync --
something that I am doing to i810_audio at least.
ac97_codec.h should stay where it is, until OSS drivers are removed from
the tree.
Jeff
next prev parent reply other threads:[~2004-11-30 18:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-30 1:31 [2.6 patch] move OSS ac97_codec.h to sound/oss/ Adrian Bunk
2004-11-30 1:37 ` Al Viro
2004-11-30 1:52 ` Adrian Bunk
2004-11-30 15:54 ` Alan Cox
2004-11-30 17:56 ` Jeff Garzik [this message]
2004-11-30 5:32 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41ACB434.4030100@pobox.com \
--to=jgarzik@pobox.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=bunk@stusta.de \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@parcelfarce.linux.theplanet.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.