All of lore.kernel.org
 help / color / mirror / Atom feed
From: Manish Lachwani <mlachwani@mvista.com>
To: "Maciej W. Rozycki" <macro@linux-mips.org>
Cc: linux-mips@linux-mips.org, ralf@linux-mips.org
Subject: Re: [PATCH] 2.4: Preemption fixes for Broadcom DMA Page operations
Date: Wed, 01 Dec 2004 16:58:19 -0800	[thread overview]
Message-ID: <41AE68AB.8010801@mvista.com> (raw)
In-Reply-To: <Pine.LNX.4.58L.0412020041420.20966@blysk.ds.pg.gda.pl>

Hi Maciej,

Maciej W. Rozycki wrote:
> On Wed, 1 Dec 2004, Manish Lachwani wrote:
> 
> 
>>The attached patch implements preempt_disable/preempt_enable around the
>>SB1 DMA page operations. Please review ...
> 
> 
>  Why is it needed?
> 
>  Also I think these:
> 
> -   if [ "$CONFIG_SIBYTE_SB1250" = "y" ]; then
> +   if [ "$CONFIG_SIBYTE_BOARD" = "y" ]; then
> 
> are unrelated and inaccurate.  The devices are internal to the SoCs and 
> not strictly board-dependent.  How about:
> 
> +   if [ "$CONFIG_SIBYTE_SB1250" = "y" || "$CONFIG_SIBYTE_BCM112X" = "y"]; then

Actually, this makes more sense. I will send a new patch

Thanks
Manish Lachwani

> 
> at the very least, or perhaps using reverse dependencies?
> 
>  Maciej

      reply	other threads:[~2004-12-02  0:58 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-12-02  0:33 [PATCH] 2.4: Preemption fixes for Broadcom DMA Page operations Manish Lachwani
2004-12-02  0:49 ` Ralf Baechle
2004-12-02  0:52 ` Maciej W. Rozycki
2004-12-02  0:58   ` Manish Lachwani [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=41AE68AB.8010801@mvista.com \
    --to=mlachwani@mvista.com \
    --cc=linux-mips@linux-mips.org \
    --cc=macro@linux-mips.org \
    --cc=ralf@linux-mips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.