From: Manish Lachwani <mlachwani@mvista.com>
To: "Steven J. Hill" <sjhill@realitydiluted.com>
Cc: linux-mips@linux-mips.org
Subject: Re: [PATCH] Broadcom SWARM IDE in 2.6
Date: Thu, 02 Dec 2004 12:18:35 -0800 [thread overview]
Message-ID: <41AF789B.3030303@mvista.com> (raw)
In-Reply-To: <41AE9390.80705@realitydiluted.com>
Hi Steve,
"ide_init_default_irq" is defined in include/linux/ide.h and in
include/asm-mips/mach-generic/ide.h.
include/asm-mips/mach-generic/ide.h and include/asm-i386/ide.h are
replicas. So, this compiler warning should appear on other platforms as
well.
I have sent an email out to Jeff Garzik to understand why
"ide_init_default_irq" is redefined
Thanks
Manish Lachwani
Steven J. Hill wrote:
> Manish Lachwani wrote:
>
>>
>> I had sent an incomplete patch before. Please try out this new patch,
>> attached.
>> Let me know if it works
>>
> Manish,
>
> This patch worked, however you need to fix a compiler warning before I am
> willing to commit it. Please get rid of the warning shown below and submit
> a new patch. Thanks!
>
> -Steve
>
> *******************
>
> CC drivers/ide/ide-generic.o
> In file included from drivers/ide/ide-generic.c:13:
> include/linux/ide.h:277:1: warning: "ide_init_default_irq" redefined
> In file included from include/asm/ide.h:11,
> from include/linux/ide.h:271,
> from drivers/ide/ide-generic.c:13:
> include/asm-mips/mach-generic/ide.h:64:1: warning: this is the location
> of the previous definition
prev parent reply other threads:[~2004-12-02 20:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-30 23:00 [PATCH] Broadcom SWARM IDE in 2.6 Manish Lachwani
2004-12-02 4:01 ` Steven J. Hill
2004-12-02 20:18 ` Manish Lachwani [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41AF789B.3030303@mvista.com \
--to=mlachwani@mvista.com \
--cc=linux-mips@linux-mips.org \
--cc=sjhill@realitydiluted.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.