From: Rene Herman <rene.herman@keyaccess.nl>
To: matthieu castet <castet.matthieu@free.fr>
Cc: Adam Belay <ambx1@neo.rr.com>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [2.6.9+] PnPBIOS: Missing SMALL_TAG_ENDDEP tag
Date: Mon, 06 Dec 2004 02:04:22 +0100 [thread overview]
Message-ID: <41B3B016.4010906@keyaccess.nl> (raw)
In-Reply-To: <41B3ABFE.5090105@free.fr>
[-- Attachment #1: Type: text/plain, Size: 595 bytes --]
matthieu castet wrote:
>> - if (option_independent == option)
>> - printk(KERN_WARNING "PnPBIOS: Missing
>> SMALL_TAG_STARTDEP tag\n");
>
> this one shouldn't be removed
>
>> option = option_independent;
>> break;
>>
>> case SMALL_TAG_END:
>> - if (option_independent != option)
>> - printk(KERN_WARNING "PnPBIOS: Missing
>> SMALL_TAG_ENDDEP tag\n");
>
> ok for this one, may be change it to pnp_dbg(...)
Works for me to. Updated patch attached that only removes the missing
ENDDEP warning.
Rene.
[-- Attachment #2: linux-2.6.10-rc3_rsparser2.diff --]
[-- Type: text/x-patch, Size: 481 bytes --]
--- linux-2.6.10-rc3.orig/drivers/pnp/pnpbios/rsparser.c 2004-12-04 03:10:03.000000000 +0100
+++ linux-2.6.10-rc3/drivers/pnp/pnpbios/rsparser.c 2004-12-06 01:59:44.000000000 +0100
@@ -439,11 +439,7 @@
break;
case SMALL_TAG_END:
- if (option_independent != option)
- printk(KERN_WARNING "PnPBIOS: Missing SMALL_TAG_ENDDEP tag\n");
- p = p + 2;
- return (unsigned char *)p;
- break;
+ return p + 2;
default: /* an unkown tag */
len_err:
next prev parent reply other threads:[~2004-12-06 1:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-06 0:35 [2.6.9+] PnPBIOS: Missing SMALL_TAG_ENDDEP tag Rene Herman
2004-12-06 0:46 ` matthieu castet
2004-12-06 1:04 ` Rene Herman [this message]
2004-12-06 2:42 ` Adam Belay
2004-12-06 3:06 ` Rene Herman
2004-12-06 16:59 ` Adam Belay
2004-12-06 21:04 ` Rene Herman
2004-12-07 0:03 ` Adam Belay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41B3B016.4010906@keyaccess.nl \
--to=rene.herman@keyaccess.nl \
--cc=ambx1@neo.rr.com \
--cc=castet.matthieu@free.fr \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.