All of lore.kernel.org
 help / color / mirror / Atom feed
From: mds4@verizon.net (Mark Studebaker)
To: lm-sensors@vger.kernel.org
Subject: checksum in (i2c) eeprom driver
Date: Thu, 19 May 2005 06:25:26 +0000	[thread overview]
Message-ID: <41B8ED64.9020805@verizon.net> (raw)
In-Reply-To: <lNsWdTVB.1102596784.6279250.khali@localhost>

IMHO the eeprom driver is more of a demonstration driver than one of
great and obvious value, so achieving consensus on the value of sub-features
(checksum, Vaio) is difficult, and performace concerns are secondary.
So I don't see any value removing the code. If you want to make it
super-clean shouldn't the Vaio stuff come out too?
But I'm sure you'll disagree...
mds

Jean Delvare wrote:
> On 2004-12-09, Mark Studebaker wrote:
> 
> 
>>I think the checksum code is useful because checksum=1 prevents the module
>>from claiming ddc monitor eeproms and other devices in its address space
>>50-57.
> 
> 
> DDC monitor EEPROMs *are* EEPROMs so there is no reason to exclude them
> from this driver. We used to have a specific (ddcmon) driver for these
> but this too is an error IMHO. Developping different eeprom drivers for
> different natures of eeproms is silly (how many more?). What the ddcmon
> driver was doing really belongs to user-space, not kernel-space.
> 
> There are not that many non-EEPROMs chips in the 0x50-0x57 range, only
> the Maxim MAX6900 RTC according to sensors-detect (quite a rare chip at
> that, we don't even have a driver for it yet).
> 
> 
>>Since detection for eeproms is otherwise poor, it's the only way we have
>>for robust detection.
> 
> 
> Except that it only works with memory module EEPROMs.
> 
> If the checksumming was that important, I guess it would have been the
> default, which it was not. If it is there for the sole purpose of
> allowing the user to prevent the eeprom driver from taking over
> non-eeprom chips, then the "ignore" module parameter can be used to
> achieve the same effect, faster, plus it is configurable on a
> per-address basis, while the checksum parameter isn't.
> 
> Thanks,
> --
> Jean Delvare
> 
> 

  parent reply	other threads:[~2005-05-19  6:25 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-12-09 12:53 checksum in (i2c) eeprom driver Jean Delvare
2005-05-19  6:25 ` Jean Delvare
2005-05-19  6:25 ` Mark Studebaker
2004-12-09 14:45   ` Jean Delvare
2005-05-19  6:25     ` Jean Delvare
2004-12-09 23:17     ` Greg KH
2005-05-19  6:25       ` Greg KH
2005-05-19  6:25 ` Mark Studebaker [this message]
2004-12-10  8:42   ` Jean Delvare
2005-05-19  6:25     ` Jean Delvare
2004-12-15  0:57     ` Mark M. Hoffman
2005-05-19  6:25       ` Mark M. Hoffman
2004-12-15  9:17       ` Jean Delvare
2005-05-19  6:25         ` Jean Delvare

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=41B8ED64.9020805@verizon.net \
    --to=mds4@verizon.net \
    --cc=lm-sensors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.