All of lore.kernel.org
 help / color / mirror / Atom feed
From: HoJin <jhfami@yahoo.co.kr>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] BUGFIX: serial setting for kgdb
Date: Sat, 11 Dec 2004 11:38:36 +0900	[thread overview]
Message-ID: <41BA5DAC.9000008@yahoo.co.kr> (raw)

Hi,

 KGDB_SMC_INDEX must be used as the index for brg_map, but it is used
direclty. (compared with function serial_init)
So it does not work properly. I have tested it and it works fine.

I noticed the same problem with 'serial_scc.c', but I could not test it yet.

Patch for only for 'serial_smc.c' is attached.

Index: cpu/mpc8260/serial_smc.c
===================================================================
--- cpu/mpc8260/serial_smc.c    (revision 65)
+++ cpu/mpc8260/serial_smc.c    (working copy)
@@ -360,10 +360,10 @@
        /* Set up the baud rate generator.
        */
 #if defined(CONFIG_KGDB_USE_EXTC)
-       m8260_cpm_extcbrg(KGDB_SMC_INDEX, speed,
+       m8260_cpm_extcbrg(brg_map[KGDB_SMC_INDEX], speed,
                CONFIG_KGDB_EXTC_RATE, CONFIG_KGDB_EXTC_PINSEL);
 #else
-       m8260_cpm_setbrg(KGDB_SMC_INDEX, speed);
+       m8260_cpm_setbrg(brg_map[KGDB_SMC_INDEX], speed);
 #endif

        /* Make the first buffer the only buffer.

-- 
Hojin

             reply	other threads:[~2004-12-11  2:38 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-12-11  2:38 HoJin [this message]
2005-08-05 23:22 ` [U-Boot-Users] [PATCH] BUGFIX: serial setting for kgdb Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=41BA5DAC.9000008@yahoo.co.kr \
    --to=jhfami@yahoo.co.kr \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.