All of lore.kernel.org
 help / color / mirror / Atom feed
From: Carl-Daniel Hailfinger <c-d.hailfinger.kernel.2004@gmx.net>
To: Yasuyuki Kozakai <yasuyuki.kozakai@toshiba.co.jp>
Cc: netfilter-devel@lists.netfilter.org
Subject: Re: [PATCH] remove overzealous checks in REJECT target
Date: Thu, 16 Dec 2004 00:31:47 +0100	[thread overview]
Message-ID: <41C0C963.4040309@gmx.net> (raw)
In-Reply-To: <200412020617.iB26H6ut018405@toshiba.co.jp>

Yasuyuki Kozakai schrieb:
> I think so. This check isn't needed.
> 
> And I found strange codes after this check: directly access to the data
> in skb.h and overwriting ICMP header with same data.
> 
> I think we should use skb_header_pointer() to get UDP/ICMP header.
> 
> Signed-off-by: Yasuyuki KOZAKAI <yasuyuki.kozakai@toshiba.co.jp>

When will this patch get into mainline?

Regards,
Carl-Daniel
-- 
http://www.hailfinger.org/

      reply	other threads:[~2004-12-15 23:31 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-12-01  6:41 [PATCH] remove overzealous checks in REJECT target Carl-Daniel Hailfinger
2004-12-02  6:17 ` Yasuyuki Kozakai
2004-12-15 23:31   ` Carl-Daniel Hailfinger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=41C0C963.4040309@gmx.net \
    --to=c-d.hailfinger.kernel.2004@gmx.net \
    --cc=netfilter-devel@lists.netfilter.org \
    --cc=yasuyuki.kozakai@toshiba.co.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.