Re: [PATCH] Avoid compile warnings on Sibyte using 2.6.10-rc3

[Manish Lachwani <mlachwani@mvista.com>]

On a side note, I think this problem will appear on other arches as well 
when running in UP mode.

Thanks
Manish Lachwani


Steven J. Hill wrote:

> Manish Lachwani wrote:
>
>>
>> When did you last sync with CVS?  There was a change introduced :
>
> Literally 10 minutes ago and I did a fresh compile.
>
>> And if running Sibyte in UP mode, cpu_icache_snoops_remote_store is 
>> redefined
>>
> I do not run in UP mode, so that is why I did not see it. I suggest
> a different version attached. How does that work for you?
>
> -Steve
>
>------------------------------------------------------------------------
>
>Index: cpu-features.h
>===================================================================
>RCS file: /home/cvs/linux/include/asm-mips/cpu-features.h,v
>retrieving revision 1.9
>diff -u -r1.9 cpu-features.h
>--- cpu-features.h	7 Dec 2004 02:08:34 -0000	1.9
>+++ cpu-features.h	16 Dec 2004 03:42:03 -0000
>@@ -87,13 +87,13 @@
>  * that did the store so we can't optimize this into only doing the flush on
>  * the local CPU.
>  */
>-#ifdef CONFIG_SMP
> #ifndef cpu_icache_snoops_remote_store
>+#ifdef CONFIG_SMP
> #define cpu_icache_snoops_remote_store	(cpu_data[0].icache.flags & MIPS_IC_SNOOPS_REMOTE)
>-#endif
> #else
> #define cpu_icache_snoops_remote_store	1
> #endif
>+#endif
> 
> /*
>  * Certain CPUs may throw bizarre exceptions if not the whole cacheline
>  
>