From: Jim Nelson <james4765@verizon.net>
To: kernel-janitors@vger.kernel.org
Subject: Re: [KJ] Re: riscom8: replace cli()/sti()
Date: Mon, 20 Dec 2004 21:35:19 +0000 [thread overview]
Message-ID: <41C74597.5000109@verizon.net> (raw)
[-- Attachment #1: Type: text/plain, Size: 1175 bytes --]
Domen Puncer wrote:
> On 15/12/04 23:45 -0600, james4765@verizon.net wrote:
>
>>This is an attempt to get the riscom8 driver working on SMP. I think I did it
>>properly (per what Documentation/cli-sti-removal.txt details).
>
>
> rc_interrupt also needs to protect data with locks (on UP it was ok,
> because interrupts were disabled).
>
> Around line 1130 there are two msleep_interruptible calls under lock
> (this was wrong before too).
>
> Some functions don't need to save flags, because you know they are
> never called from interrupt (all from riscom_ops?).
>
> IMHO it would be nice to notice somewhere what is protected by lock
> (rc_board and rc_port structures); and it would probably be better to
> have a lock per board in riscom_board struct.
>
>
> Domen
>
I had thought the same re putting the spinlock in the per-board structure (after
submitting all of these - of course) - and got a lot of other pointers on how to
make things SMP-correct. Go ahead and disregard this set of patches - I'll have
to take a more careful look at each one of them.
I thought I had seen some sleep-while-locked problems, but thought I was just
reading it wrong.
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
reply other threads:[~2004-12-20 21:35 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41C74597.5000109@verizon.net \
--to=james4765@verizon.net \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.