From: walter harms <wharms@bfs.de>
To: kernel-janitors@vger.kernel.org
Subject: Re: [KJ] [PATCH] lcd: fix memory leak, code cleanup
Date: Tue, 21 Dec 2004 08:15:50 +0000 [thread overview]
Message-ID: <41C7DBB6.8070105@bfs.de> (raw)
In-Reply-To: <20041221015120.29110.98832.48706@localhost.localdomain>
[-- Attachment #1: Type: text/plain, Size: 655 bytes --]
Hi James,
misc_register() can fail.
ret=misc_register(&lcd_dev);
if (ret < 0) {
pr_info("misc_register failed in %s\n",__FUNCTION__);
return -ENOMEM;
}
re,
walter
> }
>
> @@ -613,7 +615,7 @@
> {
> unsigned long data;
>
> - printk("%s\n", LCD_DRIVER);
> + pr_info("%s\n", LCD_DRIVER);
> misc_register(&lcd_dev);
>
> /* Check region? Naaah! Just snarf it up. */
> @@ -623,7 +625,7 @@
> data = LCDReadData;
> if ((data & 0x000000FF) == (0x00)) {
> lcd_present = 0;
> - printk("LCD Not Present\n");
> + pr_info(LCD "LCD Not Present\n");
> } else {
> lcd_present = 1;
> WRITE_GAL(kGal_DevBank2PReg, kGal_DevBank2Cfg);
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
next prev parent reply other threads:[~2004-12-21 8:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-21 1:50 [KJ] [PATCH] lcd: fix memory leak, code cleanup James Nelson
2004-12-21 1:50 ` James Nelson
2004-12-21 8:15 ` walter harms [this message]
2004-12-21 12:06 ` [KJ] " Domen Puncer
2004-12-21 12:06 ` Domen Puncer
2004-12-22 3:45 ` [KJ] " Jim Nelson
2004-12-22 3:45 ` Jim Nelson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41C7DBB6.8070105@bfs.de \
--to=wharms@bfs.de \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.