Re: [PATCH kNFSd 4 of 23] Preparation for delegation: client callback probe

[Mike Waychison <Michael.Waychison@Sun.COM>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Lever, Charles wrote:
> mike-
> 
> the latest client side transport switch patches are here:
> 
>   http://troy.citi.umich.edu/~cel/linux-2.6/2.6.9-a/release-notes.html
> 
> for your review.  i don't think these are going in any time soon.
> 
> we need some time to consider the port number issues.  can the patch
> with the borg designation 4 of 23 go in without the port number change
> you suggested?

It can, but it's a scaling issue that early adopters are going to hit.
As long as the port number stuff is forthcoming, I don't see any issue
with this patch.


> 
> 
> 
>>-----Original Message-----
>>From: Mike Waychison [mailto:Michael.Waychison@Sun.COM] 
>>Sent: Tuesday, December 21, 2004 10:56 AM
>>To: William A.(Andy) Adamson
>>Cc: NeilBrown; Andrew Morton; nfs@lists.sourceforge.net
>>Subject: Re: [NFS] [PATCH kNFSd 4 of 23] Preparation for 
>>delegation: client callback probe
>>
>>
> William A.(Andy) Adamson wrote:
> 
>>the NFSv4.0 callback client and server do not use reserved 
> 
> ports. this 
> 
>>makes
>>the use of delegations through firewalls or to a NAT 
> 
> network fail.  this is 
> 
>>fixed in the proposed NFSv4.1 minor version 'sessions' 
> 
> feature which allows 
> 
>>for the use of the NFSv4 reserved port 2049 for callbacks.
> 
> 
> Hmm, in that case, we might want to modify the 
> xprt_create_proto call somehow to reflect that we don't need 
> a port < XPRT_MAX_RESVPORT(800), which would limit the number 
> of clients possible.
> 
> I'd patch something up, but I'm not sure where that stands 
> with the transport switch work.
> 
> 
>>-->Andy
> 
> 
>>NeilBrown wrote:
> 
> 
>>>client callback rpc to probe the callback
>>>channel on setclientid with a null request.
> 
> 
>>...
> 
> 
> 
>>>+/*
>>>+ * Set up the callback client and put a NFSPROC4_CB_NULL on the 
>>>+wire...  */ void
>>>+nfsd4_probe_callback(struct nfs4_client *clp)
>>>+{
>>>+	struct sockaddr_in	addr;
>>>+	struct nfs4_callback    *cb = &clp->cl_callback;
>>>+	struct rpc_timeout	timeparms;
>>>+	struct rpc_xprt *	xprt;
>>>+	struct rpc_program *	program = &cb->cb_program;
>>>+	struct rpc_stat *	stat = &cb->cb_stat;
>>>+	struct rpc_clnt *	clnt;
>>>+	struct rpc_message msg = {
>>>+		.rpc_proc       = 
> 
> &nfs4_cb_procedures[NFSPROC4_CLNT_CB_NULL],
> 
>>>+		.rpc_argp       = clp,
>>>+	};
>>>+	char                    hostname[32];
>>>+	int status;
>>>+
>>>+	dprintk("NFSD: probe_callback. cb_parsed %d cb_set %d\n",
>>>+			cb->cb_parsed, atomic_read(&cb->cb_set));
>>>+	if (!cb->cb_parsed || atomic_read(&cb->cb_set))
>>>+		return;
>>>+
>>>+	/* Initialize address */
>>>+	memset(&addr, 0, sizeof(addr));
>>>+	addr.sin_family = AF_INET;
>>>+	addr.sin_port = htons(cb->cb_port);
>>>+	addr.sin_addr.s_addr = htonl(cb->cb_addr);
>>>+
>>>+	/* Initialize timeout */
>>>+	timeparms.to_initval = (NFSD_LEASE_TIME/4) * HZ;
>>>+	timeparms.to_retries = 5;
>>>+	timeparms.to_maxval = (NFSD_LEASE_TIME/2) * HZ;
>>>+	timeparms.to_exponential = 1;
>>>+
>>>+	/* Create RPC transport */
>>>+	if (!(xprt = xprt_create_proto(IPPROTO_TCP, &addr, 
> 
> &timeparms))) {
> 
>>>+		dprintk("NFSD: couldn't create callback transport!\n");
>>>+		goto out_err;
>>>+	}
>>>+
>>>+	/* Initialize rpc_program */
>>>+	program->name = "nfs4_cb";
>>>+	program->number = cb->cb_prog;
>>>+	program->nrvers = 
> 
> sizeof(nfs_cb_version)/sizeof(nfs_cb_version[0]);
> 
>>>+	program->version = nfs_cb_version;
>>>+	program->stats = stat;
>>>+
>>>+	/* Initialize rpc_stat */
>>>+	memset(stat, 0, sizeof(struct rpc_stat));
>>>+	stat->program = program;
>>>+
>>>+	/* Create RPC client
>>>+ 	 *
>>>+	 * XXX AUTH_UNIX only - need AUTH_GSS....
>>>+	 */
>>>+	sprintf(hostname, "%u.%u.%u.%u", NIPQUAD(addr.sin_addr.s_addr));
>>>+	if (!(clnt = rpc_create_client(xprt, hostname, program, 
> 
> 1, RPC_AUTH_UNIX))) {
> 
>>>+		dprintk("NFSD: couldn't create callback client\n");
>>>+		goto out_xprt;
>>>+	}
> 
>>Out of curiosity, does this have to be a reserved port?
> 
>>--
>>Mike Waychison
>>Sun Microsystems, Inc.
>>1 (650) 352-5299 voice
>>1 (416) 202-8336 voice
> 
>>~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>>NOTICE:  The opinions expressed in this email are held by 
> 
> me, and may 
> 
>>not represent the views of Sun Microsystems, Inc. 
>>~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 
> -------------------------------------------------------
> SF email is sponsored by - The IT Product Guide
> Read honest & candid reviews on hundreds of IT Products from 
> real users. Discover which products truly live up to the 
> hype. Start reading now. http://productguide.itmanagersjournal.com/
> _______________________________________________
> NFS maillist  -  NFS@lists.sourceforge.net 
> https://lists.sourceforge.net/lists/listinfo/nfs
> 
> 
> 
> 
> 
> 
> 
>>-------------------------------------------------------
>>SF email is sponsored by - The IT Product Guide
>>Read honest & candid reviews on hundreds of IT Products from real 
>>users. Discover which products truly live up to the hype. Start 
>>reading now. http://productguide.itmanagersjournal.com/
>>_______________________________________________
>>NFS maillist  -  NFS@lists.sourceforge.net 
>>https://lists.sourceforge.net/lists/listinfo/nfs
> 
> 
> --
> Mike Waychison
> Sun Microsystems, Inc.
> 1 (650) 352-5299 voice
> 1 (416) 202-8336 voice
> 
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> NOTICE:  The opinions expressed in this email are held by me, 
> and may not represent the views of Sun Microsystems, Inc. 
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

- -------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from
real users. Discover which products truly live up to the
hype. Start reading now.
http://productguide.itmanagersjournal.com/
_______________________________________________
NFS maillist  -  NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/n> fs



- --
Mike Waychison
Sun Microsystems, Inc.
1 (650) 352-5299 voice
1 (416) 202-8336 voice

~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
NOTICE:  The opinions expressed in this email are held by me,
and may not represent the views of Sun Microsystems, Inc.
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.5 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFByFPLdQs4kOxk3/MRAkqZAKCDKgSjaQ8bOClJXtLEHFUgVfSSxQCdE/PN
hUW11mLO1c7Ljsdoq1Q3V8M=
=DS14
-----END PGP SIGNATURE-----


-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now. 
http://productguide.itmanagersjournal.com/
_______________________________________________
NFS maillist  -  NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs