From: Jeff Garzik <jgarzik@pobox.com>
To: David Brownell <david-b@pacbell.net>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Greg Kroah-Hartman <greg@kroah.com>,
Linus Torvalds <torvalds@osdl.org>
Subject: Re: [PATCH] USB: fix Scheduling while atomic warning when resuming.
Date: Wed, 22 Dec 2004 00:27:28 -0500 [thread overview]
Message-ID: <41C905C0.9000705@pobox.com> (raw)
In-Reply-To: <200412212059.15426.david-b@pacbell.net>
David Brownell wrote:
> On Tuesday 21 December 2004 8:46 pm, Jeff Garzik wrote:
>
>>>If that lock were dropped, what would prevent other tasks from
>>>touching the hardware while it's sending RESUME signaling down
>>>the bus, and thereby mucking up the resume sequence?
>>
>>Precisely what other tasks are active for this hardware, during resume?
>
>
> There's no guarantee that suspend() and resume() methods
> are only called during system-wide suspend and resume.
That is precisely the reason why I am concerned. If it was only during
system-wide resume, the impact of the very-long mdelay() would be more
difficult to notice.
You also ignored my question :)
If the PCI layer is calling the resume method for a PCI device while
simultaneously calling the suspend method, that's a PCI layer problem.
Similarly, If the USB layer is calling into your driver while you are
resuming, something is broken and it ain't your locking.
Jeff
next prev parent reply other threads:[~2004-12-22 5:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200412220103.iBM13wS0002158@hera.kernel.org>
2004-12-22 3:48 ` [PATCH] USB: fix Scheduling while atomic warning when resuming Jeff Garzik
2004-12-22 4:22 ` David Brownell
2004-12-22 4:46 ` Jeff Garzik
2004-12-22 4:59 ` David Brownell
2004-12-22 5:27 ` Jeff Garzik [this message]
2004-12-22 11:59 ` Benjamin Herrenschmidt
2004-12-22 16:16 ` David Brownell
2004-12-22 16:35 ` Benjamin Herrenschmidt
2004-12-22 16:14 ` David Brownell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41C905C0.9000705@pobox.com \
--to=jgarzik@pobox.com \
--cc=david-b@pacbell.net \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.