All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: Roberto Nibali <ratz@tac.ch>
Cc: netfilter-devel@lists.netfilter.org
Subject: Re: [PATCH 2.4.x][RFC] enlarge struct ipt_log_info prefix to 62 bytes
Date: Wed, 22 Dec 2004 12:47:17 +0100	[thread overview]
Message-ID: <41C95EC5.6090803@trash.net> (raw)
In-Reply-To: <41C6BDC7.8060507@tac.ch>

Roberto Nibali wrote:

> Concerning netfilter there is one I think others might "benefit" from as 
> well. Here's the patch we're using to enlarge the prefix member of the 
> struct ipt_log_info structure in ipt_LOG.h:
> 
>  struct ipt_log_info {
>         unsigned char level;
>         unsigned char logflags;
> -       char prefix[30];
> +       char prefix[62];
>  };

This breaks binary compatibility, so we can't put it in.
Otherwise I'd agree, 30 byte is kind of small. Maybe it
will be possible with Rusty's and Pablo's work to extend
structures without breaking compatibility.

Regards
Patrick

  reply	other threads:[~2004-12-22 11:47 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-12-20 11:55 [PATCH 2.4.x][RFC] enlarge struct ipt_log_info prefix to 62 bytes Roberto Nibali
2004-12-22 11:47 ` Patrick McHardy [this message]
2004-12-23  1:09   ` Herve Eychenne

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=41C95EC5.6090803@trash.net \
    --to=kaber@trash.net \
    --cc=netfilter-devel@lists.netfilter.org \
    --cc=ratz@tac.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.